-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI and Build tasks for docker images #46
Comments
TroyKomodo
added a commit
that referenced
this issue
Feb 24, 2023
Adding docker builds to CI so that we can have regularly updated docker images pushed to GHCR. closes #46
TroyKomodo
added a commit
that referenced
this issue
Feb 24, 2023
Adding docker builds to CI so that we can have regularly updated docker images pushed to GHCR. closes #46
TroyKomodo
pushed a commit
that referenced
this issue
Feb 24, 2023
Closes #35 fix: switch to scss feat: finish up layout chore: switch to mask + small other fixes Switched to mask as our task runner from Just. Mask seems to provide a much nicer cli than just and also is much easier to write than the just files, since its markdown. Ideally they should add support for submoudles and some things to help with code duplication. Like global variables, global scripts, cascading flags, catch all extra arguments, ect... However these are not big enough issues for us to not use it since just/make is very unmaintainable and very messy when we have a lot of tasks. I made an issue on their repo for the submodule idea. jacobdeichert/mask#96 Some small fixes: - .gitignores on mac - prettier not formatting all files feat: start landing page Closes #35 fix: switch to scss fix: remove unused file feat: fix magic text positioning chore: format fix: capitalization chore: add code coverage Add code coverage with Codecov. closes #50 feat: add blurred circles to background chore: format fix: remove unused <script> fix: text selection on top of blurred circles feat: added blurred-circle animation feat(api): initial api implementation + glibc Upon testing the API we noticed that when the app is compiled with musl the API would perform roughly 80% worse than the glibc counter part. We will have to do real benchmarks to see where this performance drop off is coming from and likely have to ticket it to the musl / rust / tokio devs. ci: add docker ci builds Adding docker builds to CI so that we can have regularly updated docker images pushed to GHCR. closes #46
TroyKomodo
pushed a commit
that referenced
this issue
Feb 24, 2023
Closes #35 fix: switch to scss feat: finish up layout chore: switch to mask + small other fixes Switched to mask as our task runner from Just. Mask seems to provide a much nicer cli than just and also is much easier to write than the just files, since its markdown. Ideally they should add support for submoudles and some things to help with code duplication. Like global variables, global scripts, cascading flags, catch all extra arguments, ect... However these are not big enough issues for us to not use it since just/make is very unmaintainable and very messy when we have a lot of tasks. I made an issue on their repo for the submodule idea. jacobdeichert/mask#96 Some small fixes: - .gitignores on mac - prettier not formatting all files feat: start landing page Closes #35 fix: switch to scss fix: remove unused file feat: fix magic text positioning chore: format fix: capitalization chore: add code coverage Add code coverage with Codecov. closes #50 feat: add blurred circles to background chore: format fix: remove unused <script> fix: text selection on top of blurred circles feat: added blurred-circle animation feat(api): initial api implementation + glibc Upon testing the API we noticed that when the app is compiled with musl the API would perform roughly 80% worse than the glibc counter part. We will have to do real benchmarks to see where this performance drop off is coming from and likely have to ticket it to the musl / rust / tokio devs. ci: add docker ci builds Adding docker builds to CI so that we can have regularly updated docker images pushed to GHCR. closes #46
TroyKomodo
pushed a commit
to mmattbtw/scuffle
that referenced
this issue
Feb 24, 2023
Closes ScuffleCloud#35 fix: switch to scss feat: finish up layout chore: switch to mask + small other fixes Switched to mask as our task runner from Just. Mask seems to provide a much nicer cli than just and also is much easier to write than the just files, since its markdown. Ideally they should add support for submoudles and some things to help with code duplication. Like global variables, global scripts, cascading flags, catch all extra arguments, ect... However these are not big enough issues for us to not use it since just/make is very unmaintainable and very messy when we have a lot of tasks. I made an issue on their repo for the submodule idea. jacobdeichert/mask#96 Some small fixes: - .gitignores on mac - prettier not formatting all files feat: start landing page Closes ScuffleCloud#35 fix: switch to scss fix: remove unused file feat: fix magic text positioning chore: format fix: capitalization chore: add code coverage Add code coverage with Codecov. closes ScuffleCloud#50 feat: add blurred circles to background chore: format fix: remove unused <script> fix: text selection on top of blurred circles feat: added blurred-circle animation feat(api): initial api implementation + glibc Upon testing the API we noticed that when the app is compiled with musl the API would perform roughly 80% worse than the glibc counter part. We will have to do real benchmarks to see where this performance drop off is coming from and likely have to ticket it to the musl / rust / tokio devs. ci: add docker ci builds Adding docker builds to CI so that we can have regularly updated docker images pushed to GHCR. closes ScuffleCloud#46
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We should extend our build to push docker images when the item is merged into a feature branch / main branch and then if a tag is made we should tag the versions.
We should also add automatic CVE scanning on our docker images.
The text was updated successfully, but these errors were encountered: