Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mermaid diagram rendering failing #638

Closed
Hydrophobefireman opened this issue Dec 19, 2023 · 2 comments
Closed

Mermaid diagram rendering failing #638

Hydrophobefireman opened this issue Dec 19, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@Hydrophobefireman
Copy link
Contributor

Hydrophobefireman commented Dec 19, 2023

Describe the bug
I believe the last 2 commits broke mermaid diagram rendering.

To Reproduce
Compare the build from 78b33fc -> https://2a583307.quartz-1h4.pages.dev/features/Mermaid-diagrams
to the current prod build https://quartz.jzhao.xyz/features/Mermaid-diagrams (
5152d32 ) (permalink: https://2a583307.quartz-1h4.pages.dev/features/Mermaid-diagrams)

Expected behavior
A rendering of the mermaid diagram, instead we get a codeblock again.

Screenshots
Expected:
image
Current:
image

I believe the issue stems from the generated HTML.
Here's the relevant HTML from the previous versions:
image

Here's the current HTML:
image

@jackyzha0
Copy link
Owner

Pending a fix from upstream :) thanks for reporting

@jackyzha0
Copy link
Owner

Have a workaround in place for now but let's hope it's fixed upstream 🤞

gamberoillecito pushed a commit to gamberoillecito/QuantumEngPolitoNotes that referenced this issue Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants