rehype-pretty-code doesn't preserve the language if it's unknown

[jackyzha0]

Before upgrading to 0.12.1, Quartz used to have code that looks like this:

visit(tree, "code", (node: Code) => {
  if (node.lang === "mermaid") {
    node.data = {
      hProperties: {
        className: ["mermaid"],
      },
    }
  }
})

This would run in a remark plugin before rehype-pretty-code does. I'm guessing that the old implementation would respect the hProperties on the code block but shikiji straight up just replaces it? In any case, this would also be solved if data-language contained the code block language even if it isn't a recognized language (right now, it seems to default to the empty string if it's not detected)

[jackyzha0]

Related issue within Quartz: jackyzha0/quartz#638

[jackyzha0]

#69 (comment) the crux of this issue seems to be the same one that this other comment mentions

is there a way to keep node.properties after it gets transformed into a div?

[atomiks]

@jackyzha0 I think the issue was the transformation of properties wasn't respecting the existing properties, can you check if the linked PR ^ fixes it?