Skip to content
This repository has been archived by the owner on Apr 10, 2023. It is now read-only.

Fix the problem with comma and b in russian keybord layout #140

Merged
merged 1 commit into from
Apr 16, 2017

Conversation

AstraSerg
Copy link
Contributor

Hi
I fix the problem listed here
A small side effect appers: tag's text will not breakdown when author press comma key, but display the comma itself. And tags will be splitted by this commas only after submitting the RM issue. This is not very good, but acceptable in my case. Pull my fix if you consider it acceptable too.

Here is how russian layout looks like:
ru_kb
:)

@sdwolfz sdwolfz assigned sdwolfz and marius-balteanu and unassigned sdwolfz May 19, 2016
@sdwolfz
Copy link
Collaborator

sdwolfz commented Jan 10, 2017

I'm not a fan of this since it implies modifying a 3'rd party library directly in out repo.

I will look into switching to another JavaScript library for tagging. Maybe select2 or taggle.

@marius-balteanu
Copy link
Collaborator

@SDWolf, I agree with you, but in this particular case I think that we can accept the PR. The tag-it library seems to be unmaintained (last commit on Nov 18, 2014). For sure, in a next version of the plugin, we can replace the library with a better one (we should discuss about this in other issue).

@sdwolfz sdwolfz self-requested a review January 17, 2017 09:17
@marius-balteanu marius-balteanu merged commit 1f49e35 into ixti:master Apr 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants