Skip to content
This repository has been archived by the owner on Apr 10, 2023. It is now read-only.

Cyrillic «Б» is not supported in tag names #87

Closed
peremenov opened this issue Mar 28, 2014 · 15 comments
Closed

Cyrillic «Б» is not supported in tag names #87

peremenov opened this issue Mar 28, 2014 · 15 comments

Comments

@peremenov
Copy link

Cyrillic «Б» is not supported in tag names: you cannot type a tag which includes a capital «Б» or a small «б» since plugin considers it to be a Latin comma.

Невозможно напечатать букву «Б» в имени метки.

@PowerKiKi
Copy link
Collaborator

Could you identify if the the bug is on client-side or server-side ?

On client-side we use the library https://github.com/aehlke/tag-it, but our
version is two years old
nowhttps://github.com/ixti/redmine_tags/commit/6cbf7cc38113c435828663a50e74bc49740bc2f0,
and maybe updating it could solve the issue... Or switch to another library
(I am thinking Select2)...

@peremenov
Copy link
Author

I think the bug is on client-side.
Client-side plugin uses key code (instead of symbol code) for identification of comma-sign. «Б» key on Russian keyboard layout is the same as «,» (which has the same key code) on English layout.

P.S. Try to update tag-it library.

@peremenov
Copy link
Author

Looks like this is not fixed in tag-it ( aehlke/tag-it#251 )

@PowerKiKi
Copy link
Collaborator

Can you confirm if it is working with Select2, on their demo page ?

@peremenov
Copy link
Author

Confirmed. Works well.

@peremenov
Copy link
Author

Probably this is a solution aehlke/tag-it#324

@marius-balteanu
Copy link
Collaborator

In order to make a little clean up on this repository, we're closing all the issues older than 1 year.

Please check the latest version of the plugin and reopen this ticket if the issue/feature is still available.

@ixti
Copy link
Owner

ixti commented Dec 10, 2015

Well, this one is actually still exist. As it's a bug in tag-it that we use.

@ixti
Copy link
Owner

ixti commented Dec 10, 2015

@marius-balteanu
Copy link
Collaborator

Ok, I'm reopening the issue.

@PowerKiKi
Copy link
Collaborator

Since my last comment on this issue Select2 had a major version released (with lots of cleanup). That may make it an even better candidate. But we should be sure that it still works with latest version before implementing it...

@marius-balteanu
Copy link
Collaborator

Ok, we'll try in the next days to move from tagit to select2.

@marius-balteanu
Copy link
Collaborator

I made some tests yesterday and I don't think that we can move now easily from tag-it to select2 v4 (latest version) because of the incompatibility with other plugins that we use in our company (A Common Libs that uses Select 2 version 3.4.1 and Restrict Tracker that depends on A Common Libs).

We can try to move to Select 3.4.1 or to wait for A Common Libs to adds Select2 v4.

@ixti
Copy link
Owner

ixti commented Dec 29, 2015

Select2 v 3.4.1 will work perfectly fine (because it does not adds tag upon special chars - it waits for user to hit enter, or unfocus of input element).

@ixti
Copy link
Owner

ixti commented Jan 19, 2018

Seems like this was fixed as of #140

@ixti ixti closed this as completed Jan 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants