Fix long playlists (100+ videos)

[SamantazFox]

This should fix issue #1883.
I've also made some changes in src/invidious/channels.cr because both channel and playlist videos require a call to [YT]/youtubei/v1/browse, so I made a common wrapper (it will ease future updates if the key or client version strings change).

[TheFrenchGhosty]

What are the differences with #1909 ?

PS: CI must be fixed.

[SamantazFox]

What are the differences with #1909 ?

All playlists mentonned there work, being 300 or 5k videos ones and the continuation token was fixed too (so we can have pages >= 2)

PS: CI must be fixed.

Yup, I know. I'll go on for the "dummy request index" (option 1), then, so if YT does take that into account in the future, that won't be a problem.

PS: Also I don't care about the bounty.

[TheFrenchGhosty]

All playlists mentonned there work, being 300 or 5k videos ones and the continuation token was fixed too (so we can have pages >= 2)

Well, this is great then!

Yup, I know. I'll go on for the "dummy request index" (option 1), then, so if YT does take that into account in the future, that won't be a problem.

Alright, I'll wait for this to be done before I ask saltycrys to review.

PS: Also I don't care about the bounty.

You're sure? You deserve it. If you really don't want it, we can send it to someone else you choose if you want.

[SamantazFox]

Alright, I'll wait for this to be done before I ask saltycrys to review.

It's fixed, all CI tests pass now :)

You're sure? You deserve it. If you really don't want it, we can send it to someone else you choose if you want.

I don't really like cryptos, tbh. Plus I stardted working on it before any bounty were added.

I know someone who was very excited about that bounty, tho :P

[TheFrenchGhosty]

I'll surely test this PR tonight, if everything works I'll merge it.

@SamantazFox what is your decision about the reward?

[SamantazFox]

@TheFrenchGhosty Ah, yeah, I didn't fix the HTML template nor the paging code.

Oh, and BTW, I don't have page 11. It stops at page 10 for me. Maybe some videos are geo-blocked?

[SamantazFox]

Here we go. That's fixed :)

[TheFrenchGhosty]

Oh, and BTW, I don't have page 11. It stops at page 10 for me. Maybe some videos are geo-blocked?

I test that on my instance on https://pussthecat.org so it's in Germany. It's possible that it's geo-bocked in France yeah.

[TheFrenchGhosty]

Tested: works perfectly!

The fact that when going over the page number you get redirect to the last page:

invidious/src/invidious/routes/playlists.cr

Line 439 in 23e5b6b

if page > page_count

is really cool too.

[TheFrenchGhosty]

Merged.

Thanks for the review @saltycrys

Thanks @SamantazFox and @tenpura-shrimp

If you really don't want the reward we'll surely just use this money for another bounty.

[SamantazFox]

The fact that when going over the page number you get redirect to the last page is really cool too.

glad you like it ^^

[TheFrenchGhosty]

@SamantazFox I mean, it's a clever way to limit it without displaying an "error" page, and actually useful. So yeah, it's cool! :)

[TheFrenchGhosty]

@SamantazFox I think this PR is breaking comments by adding ?format=html&hl=en-US&thin_mode=false at the end of the API url.

#1926

[github-actions]

This pull request has been automatically locked since there has not been any activity in it in the last 30 days. If you want to tell us about needed or wanted changes or if problems related to this code are discovered, feel free to open an issue or a new pull request.