Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

actual fix large playlists #1909

Closed
wants to merge 1 commit into from
Closed

actual fix large playlists #1909

wants to merge 1 commit into from

Conversation

tenpura-shrimp
Copy link

1615692982954
Fixes #1883
I want to be awarded the bounty associated to the issue this PR is fixing.

@TheFrenchGhosty TheFrenchGhosty added bounty need-code-review A crystal developper need to check if the code is correct. need-testing This feature needs to be deployed and tested to see if it's working, and doesn't break something labels Mar 20, 2021
@SamantazFox
Copy link
Member

The continuation (page 2,3 and so on) doesn't work.

@TheFrenchGhosty
Copy link
Member

TheFrenchGhosty commented Mar 20, 2021

@TheFrenchGhosty TheFrenchGhosty added unfinished More work is needed on this PR, or on something this PR uses. and removed need-code-review A crystal developper need to check if the code is correct. need-testing This feature needs to be deployed and tested to see if it's working, and doesn't break something labels Mar 20, 2021
@SamantazFox
Copy link
Member

Just for traceability/logs, I used the following playlists to test continuation:

https://www.youtube.com/playlist?list=PLNj_ZJF3LtBzxeoqwagc30AgrNvhSUu1L
https://www.youtube.com/playlist?list=PLj3LVjI7cF7k-LmGKRiw6XwbU8SAtQwCF

@tenpura-shrimp
Copy link
Author

closing in favor of #1911

Good work @SamantazFox

@github-actions
Copy link

github-actions bot commented Jun 8, 2021

This pull request has been automatically locked since there has not been any activity in it in the last 30 days. If you want to tell us about needed or wanted changes or if problems related to this code are discovered, feel free to open an issue or a new pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
unfinished More work is needed on this PR, or on something this PR uses.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Playlists with 100+ videos don't display any videos on any instance.
4 participants