Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce Comparison "Image By Step" calls to backend #4506

Merged
merged 3 commits into from
Aug 16, 2023
Merged

Reduce Comparison "Image By Step" calls to backend #4506

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bd7ac35
Reduce Comparison "Image By Step" calls to backend
julieg18 Aug 15, 2023
91a1b00
Merge branch 'main' into reduce-comparison-multi-img-calls
julieg18 Aug 15, 2023
a0b3538
Merge branch 'main' into reduce-comparison-multi-img-calls
mattseddon Aug 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion webview/src/plots/components/comparisonTable/cell/ComparisonTableMultiCell.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,10 @@ export const ComparisonTableMultiCell: React.FC<{
useEffect(() => {
window.clearTimeout(changeDebounceTimer.current)
changeDebounceTimer.current = window.setTimeout(() => {
if (currentStep === values?.[plot.id]?.[path]) {
const isOnMount =
values?.[plot.id]?.[path] === undefined && currentStep === 0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saw that our windows tests were sometimes failing with:

Screenshot 2023-08-15 at 7 57 34 AM

which made me realize that we were sending unneeded calls on mount.

const stepMatchesState = currentStep === values?.[plot.id]?.[path]
if (isOnMount || stepMatchesState) {
return
}
setComparisonMultiPlotValue(path, plot.id, currentStep)
Expand Down
Loading