Reduce Comparison "Image By Step" calls to backend #4506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
julieg18
commented
Aug 15, 2023
•
julieg18
commented
- stops our comparison multi image from making unneeded calls to the backend on mount
julieg18
commented
Aug 15, 2023
| @@ -30,7 +30,10 @@ export const ComparisonTableMultiCell: React.FC<{ | |||
| useEffect(() => { | |||
| window.clearTimeout(changeDebounceTimer.current) | |||
| changeDebounceTimer.current = window.setTimeout(() => { | |||
| if (currentStep === values?.[plot.id]?.[path]) { | |||
| const isOnMount = | |||
| values?.[plot.id]?.[path] === undefined && currentStep === 0 | |||
There was a problem hiding this comment.
Saw that our windows tests were sometimes failing with:
which made me realize that we were sending unneeded calls on mount.
mattseddon
approved these changes
Aug 16, 2023
|
Code Climate has analyzed commit a0b3538 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 95.2% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.