Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

telemetry string/re-assignment tweaks #626

Merged
merged 1 commit into from
Jul 6, 2022

Conversation

dacbd
Copy link
Contributor

@dacbd dacbd commented Jul 6, 2022

patch for linter

@dacbd dacbd requested a review from casperdcl July 6, 2022 17:31
@dacbd dacbd merged commit b24a317 into jsonify-telemetry Jul 6, 2022
@dacbd dacbd deleted the jsonify-telemetry-lint-patch branch July 6, 2022 17:47
@0x2b3bfa0
Copy link
Member

Thanks, Mr. Restyled! ❤️

DavidGOrtega added a commit that referenced this pull request Jul 13, 2022
* keep JSON format

* Defer as soon as possible

* Avoid panic on malformed data & rename variables

Also simplifies some logic

* string/re-assginment tweaks (#626)

* updated error checking

* handle old non-json format

* Errorf for %w

* remove unneeded code

Co-authored-by: DavidGOrtega <[email protected]>

Co-authored-by: Helio Machado <[email protected]>
Co-authored-by: Daniel Barnes <[email protected]>
Co-authored-by: DavidGOrtega <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants