Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keep JSON format #622

Merged
merged 8 commits into from
Jul 13, 2022
Merged

keep JSON format #622

merged 8 commits into from
Jul 13, 2022

Conversation

casperdcl
Copy link
Contributor

updated spec to be more compatible

@casperdcl casperdcl added bug Something isn't working technical-debt Refactoring, linting & tidying labels Jul 5, 2022
@casperdcl casperdcl requested review from DavidGOrtega, omesser and a team July 5, 2022 19:25
@casperdcl casperdcl self-assigned this Jul 5, 2022
@0x2b3bfa0 0x2b3bfa0 self-requested a review July 5, 2022 19:26
0x2b3bfa0
0x2b3bfa0 approved these changes Jul 10, 2022
View reviewed changes
Copy link
Member

@0x2b3bfa0 0x2b3bfa0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LMTM :shipit:

iterative/utils/analytics.go Outdated Show resolved Hide resolved
@DavidGOrtega DavidGOrtega mentioned this pull request Jul 12, 2022
Merged
@dacbd dacbd self-assigned this Jul 12, 2022
@dacbd dacbd requested review from DavidGOrtega and 0x2b3bfa0 July 13, 2022 00:16
DavidGOrtega
DavidGOrtega suggested changes Jul 13, 2022
View reviewed changes
iterative/utils/analytics.go Outdated Show resolved Hide resolved
@dacbd @DavidGOrtega
remove unneeded code
5951ea5 
Co-authored-by: DavidGOrtega <[email protected]>
@dacbd dacbd requested a review from DavidGOrtega July 13, 2022 16:33
DavidGOrtega
DavidGOrtega approved these changes Jul 13, 2022
View reviewed changes
iterative/utils/analytics.go Show resolved Hide resolved
@DavidGOrtega DavidGOrtega merged commit 28ce781 into master Jul 13, 2022
@DavidGOrtega DavidGOrtega deleted the jsonify-telemetry branch July 13, 2022 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dacbd dacbd dacbd left review comments

@DavidGOrtega DavidGOrtega DavidGOrtega approved these changes

@omesser omesser Awaiting requested review from omesser

@0x2b3bfa0 0x2b3bfa0 Awaiting requested review from 0x2b3bfa0

Assignees

@dacbd dacbd

@casperdcl casperdcl

Labels
bug Something isn't working technical-debt Refactoring, linting & tidying
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@casperdcl @DavidGOrtega @dacbd @0x2b3bfa0