This repository has been archived by the owner on Sep 13, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add requirements builder #434
add requirements builder #434
Changes from 40 commits
cd51b90
05b9e5c
6e6aea7
c747cc1
7654db9
407203e
fc7c3dd
4446650
df9e2a3
129ecdf
50e4e30
14a6626
7b6bc23
5537ad3
b7c1d92
1cb1d10
2171924
9161ab7
39fcd57
a449918
6239563
896a25f
e328ee8
7d83350
031a8a4
b2141d4
3080313
550db69
7ccf8e1
993409b
0d05981
4b798f2
6eea4ab
bd72738
4dabca5
6fa56ff
b5e968c
3d51c66
ecf555d
10e9e9c
0bd9007
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe
" ".join
? Will it work likepip install $(mlem build requirements -m model)
RN?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have replaced it with
" "
, butpip install $(mlem build requirements -m model)
doesn't work because of the first line with the emoji i.e.⏳️ Loading model from sk-model.mlem
.Is there a way to ignore all this
echo
related stuff?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question! This is a good example when we should try our tools in a user scenario to find out how it will work in fact :)
This is what I heard multiple times from Dmitry and Ivan, btw. See this #390 Let's discuss it there, so it won't get lost.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can add
--quiet/-q
tomlem-callback
that will disable standard cli outputThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this to be done? As a separate PR maybe? Or I need to add this
--quiet
stuff somewhere? I do see stuff related tomlem_group_callback
so wondering if it is to be accommodated there?Also, should this PR be merged since it's approved OR should we do the above first?