add requirements builder #434
Conversation
Codecov ReportBase: 87.62% // Head: 87.73% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## release/0.3.0 #434 +/- ##
=================================================
+ Coverage 87.62% 87.73% +0.10%
=================================================
Files 94 96 +2
Lines 7847 7882 +35
=================================================
+ Hits 6876 6915 +39
+ Misses 971 967 -4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Re the issue you posted about pipenv - the issue was closed in 2020, so it's a bit outdated. If you check, they are releasing quite frequently now. So don't think the project is dead, unless I'm missing something. |
You can check numerous posts on the internet: |
|
Ok, what I read in your links:
I would like to note that I'm not insisting on implementing something in particular (like I personally would consider implementing |
I have done |
madhur-tandon
force-pushed
the
feature/env-builder
branch
from
60824ef to
3d51c66
Compare
mlem/contrib/requirements.py
Outdated
| reqs = obj.requirements.of_type(req_type_cls) | ||
| if self.target is None: | ||
| reqs_representation = [r.get_repr() for r in reqs] | ||
| requirement_string = "\n".join(reqs_representation) |
There was a problem hiding this comment.
Maybe " ".join? Will it work like pip install $(mlem build requirements -m model) RN?
There was a problem hiding this comment.
I have replaced it with " ", but pip install $(mlem build requirements -m model) doesn't work because of the first line with the emoji i.e. ⏳️ Loading model from sk-model.mlem.
Is there a way to ignore all this echo related stuff?
There was a problem hiding this comment.
Good question! This is a good example when we should try our tools in a user scenario to find out how it will work in fact :)
This is what I heard multiple times from Dmitry and Ivan, btw. See this #390 Let's discuss it there, so it won't get lost.
There was a problem hiding this comment.
We can add --quiet/-q to mlem-callback that will disable standard cli output
There was a problem hiding this comment.
Is this to be done? As a separate PR maybe? Or I need to add this --quiet stuff somewhere? I do see stuff related to mlem_group_callback so wondering if it is to be accommodated there?
Also, should this PR be merged since it's approved OR should we do the above first?
Closes #209
pipas indicated by https://pip.pypa.io/en/latest/user_guide/#using-pip-from-your-programcondathrough subprocess and not the Conda Python API since that introduces a new dependency (which is not really installable by pip + conda list through the API doesn't include thepypipackages)