Skip to content
This repository has been archived by the owner on Sep 13, 2023. It is now read-only.

serve api should accept str for model argument #425

Merged
merged 1 commit into from
Oct 4, 2022

Conversation

madhur-tandon
Copy link
Contributor

Closes #412

@madhur-tandon madhur-tandon requested a review from a team October 3, 2022 11:28
@madhur-tandon madhur-tandon temporarily deployed to internal October 3, 2022 11:28 Inactive
@madhur-tandon madhur-tandon self-assigned this Oct 3, 2022
@madhur-tandon madhur-tandon temporarily deployed to internal October 3, 2022 11:31 Inactive
@madhur-tandon madhur-tandon force-pushed the str_in_model_for_serve branch from c940cb4 to 5ec5122 Compare October 3, 2022 15:56
@madhur-tandon madhur-tandon temporarily deployed to internal October 3, 2022 15:56 Inactive
@codecov
Copy link

codecov bot commented Oct 3, 2022

Codecov Report

Base: 89.39% // Head: 89.48% // Increases project coverage by +0.08% 🎉

Coverage data is based on head (5ec5122) compared to base (51f328a).
Patch coverage: 95.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #425      +/-   ##
==========================================
+ Coverage   89.39%   89.48%   +0.08%     
==========================================
  Files          81       81              
  Lines        6376     6388      +12     
==========================================
+ Hits         5700     5716      +16     
+ Misses        676      672       -4     
Impacted Files Coverage Δ
mlem/cli/main.py 68.58% <75.00%> (+3.09%) ⬆️
mlem/api/commands.py 88.88% <100.00%> (ø)
mlem/contrib/pandas.py 93.10% <100.00%> (ø)
mlem/ui.py 93.24% <100.00%> (+0.48%) ⬆️
mlem/utils/module.py 89.25% <100.00%> (-0.86%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mike0sv
Copy link
Contributor

mike0sv commented Oct 3, 2022

It's already fixed in #413

@madhur-tandon
Copy link
Contributor Author

It's already fixed in #413

Do you wanna merge it together with that or separately with this?

@madhur-tandon madhur-tandon temporarily deployed to internal October 3, 2022 19:15 Inactive
@madhur-tandon madhur-tandon temporarily deployed to internal October 3, 2022 19:30 Inactive
@madhur-tandon madhur-tandon merged commit e2edbf2 into main Oct 4, 2022
@madhur-tandon madhur-tandon deleted the str_in_model_for_serve branch October 4, 2022 12:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

mlem.api.serve does not accept str for model argument
2 participants