Skip to content
This repository has been archived by the owner on Sep 13, 2023. It is now read-only.

Add docstrings to extensions #413

Merged
merged 12 commits into from
Oct 6, 2022
Merged

Add docstrings to extensions #413

merged 12 commits into from
Oct 6, 2022

Conversation

mike0sv
Copy link
Contributor

@mike0sv mike0sv commented Sep 16, 2022

Adding docs to extensions
For now chaining to #398

close #412 as well

@mike0sv mike0sv added the plugins Plugins and extensions for MLEM! label Sep 16, 2022
@mike0sv mike0sv requested a review from a team September 16, 2022 16:58
@mike0sv mike0sv self-assigned this Sep 16, 2022
@mike0sv mike0sv temporarily deployed to internal September 16, 2022 16:58 Inactive
@mike0sv mike0sv mentioned this pull request Sep 16, 2022
3 tasks
Base automatically changed from fix/0.3-docs-feedback to release/0.3.0 September 19, 2022 14:59
Copy link
Contributor

@aguschin aguschin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you use this branch to generate docs in iterative/mlem.ai#172 ?

mlem/cli/apply.py Outdated Show resolved Hide resolved
@aguschin aguschin temporarily deployed to internal October 5, 2022 06:50 Inactive
@aguschin
Copy link
Contributor

aguschin commented Oct 5, 2022

resolved merge conflict, but your tests fail @mike0sv

@mike0sv
Copy link
Contributor Author

mike0sv commented Oct 5, 2022

Will resolve and merge after #417

@mike0sv mike0sv temporarily deployed to internal October 5, 2022 12:29 Inactive
@codecov
Copy link

codecov bot commented Oct 5, 2022

Codecov Report

Base: 86.89% // Head: 87.66% // Increases project coverage by +0.77% 🎉

Coverage data is based on head (00b5edf) compared to base (8fed003).
Patch coverage: 83.33% of modified lines in pull request are covered.

Additional details and impacted files
@@                Coverage Diff                @@
##           release/0.3.0     #413      +/-   ##
=================================================
+ Coverage          86.89%   87.66%   +0.77%     
=================================================
  Files                 94       94              
  Lines               7849     7861      +12     
=================================================
+ Hits                6820     6891      +71     
+ Misses              1029      970      -59     
Impacted Files Coverage Δ
mlem/cli/serve.py 89.47% <ø> (ø)
mlem/contrib/bitbucketfs.py 96.52% <ø> (ø)
mlem/contrib/callable.py 98.26% <ø> (ø)
mlem/contrib/catboost.py 96.87% <ø> (ø)
mlem/contrib/docker/__init__.py 100.00% <ø> (ø)
mlem/contrib/dvc.py 60.29% <ø> (ø)
mlem/contrib/fastapi.py 95.38% <ø> (ø)
mlem/contrib/github.py 94.66% <ø> (ø)
mlem/contrib/gitlabfs.py 94.59% <ø> (ø)
mlem/contrib/lightgbm.py 94.50% <ø> (ø)
... and 16 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mike0sv mike0sv temporarily deployed to internal October 5, 2022 20:45 Inactive
@mike0sv mike0sv temporarily deployed to internal October 5, 2022 21:32 Inactive
@mike0sv mike0sv merged commit f47bf34 into release/0.3.0 Oct 6, 2022
@mike0sv mike0sv deleted the fix/0.3.0-ext-docs branch October 6, 2022 12:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
plugins Plugins and extensions for MLEM!
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants