Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Nav Banner for VSCode's launch on Product Hunt #239

Merged
merged 2 commits into from
Nov 15, 2023
+5 −4
Merged

Update Nav Banner for VSCode's launch on Product Hunt #239

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c1f1e13
Update nav banner for VSCode's launch on Product Hunt
julieg18 Nov 14, 2023
d5d3f72
Improve text and update link
julieg18 Nov 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions packages/gatsby-theme-iterative/src/components/LayoutHeader/Alert/content.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,7 @@ export const AlertContent = () => (
<span role="img" aria-label="rocket">
🚀
</span>{' '}
New Release!{' '}
<Link href="https://iterative.ai/blog/dvc-3.0-ml-experiments-data-versioning/">
The DVC 3.0 Stack: Beyond the Command Line
</Link>{' '}
Help Support Our DVC for VSCode Extension on{' '}
julieg18 marked this conversation as resolved.
Show resolved Hide resolved
<Link href="https://www.producthunt.com/">Product Hunt</Link>!
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any comments on improving the text are welcome!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a link directly to VSCode's product hunt page? I'm currently just linking to the product hunt's page. cc @jendefig, @tapadipti

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @julieg18

Link: https://www.producthunt.com/posts/dvc-extension-for-vs-code

Text: Let's change to "Support our DVC Extension for VSCode on"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iterative/studio-frontend Does this appear in Studio also? If not, can we pls add it to Studio separately?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tapadipti I'm not sure what you mean - do you want us to create a similar banner on the Studio homepage?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can do as here https://iterativeai.slack.com/archives/C061NJ44KDX/p1700044523833709?thread_ts=1700036891.594709&cid=C061NJ44KDX

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/iterative/studio/pull/8250

</>
)