Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Nav Banner for VSCode's launch on Product Hunt #239

Merged
merged 2 commits into from
Nov 15, 2023
Merged

Update Nav Banner for VSCode's launch on Product Hunt #239

merged 2 commits into from
Nov 15, 2023

Conversation

julieg18
Copy link
Contributor

@julieg18 julieg18 commented Nov 14, 2023 •
edited
Loading

@julieg18 julieg18 self-assigned this Nov 14, 2023
@yathomasi yathomasi temporarily deployed to gatsby-theme-update-ban-1gtzhh November 14, 2023 16:08 Inactive
julieg18
julieg18 commented Nov 14, 2023
View reviewed changes
packages/gatsby-theme-iterative/src/components/LayoutHeader/Alert/content.tsx Outdated
The DVC 3.0 Stack: Beyond the Command Line
</Link>{' '}
Help Support Our DVC for VSCode Extension on{' '}
<Link href="https://www.producthunt.com/">Product Hunt</Link>!
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any comments on improving the text are welcome!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a link directly to VSCode's product hunt page? I'm currently just linking to the product hunt's page. cc @jendefig, @tapadipti

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @julieg18

Link: https://www.producthunt.com/posts/dvc-extension-for-vs-code

Text: Let's change to "Support our DVC Extension for VSCode on"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iterative/studio-frontend Does this appear in Studio also? If not, can we pls add it to Studio separately?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tapadipti I'm not sure what you mean - do you want us to create a similar banner on the Studio homepage?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can do as here https://iterativeai.slack.com/archives/C061NJ44KDX/p1700044523833709?thread_ts=1700036891.594709&cid=C061NJ44KDX

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/iterative/studio/pull/8250

@julieg18 julieg18 marked this pull request as ready for review November 14, 2023 16:12
@julieg18 julieg18 requested a review from a team as a code owner November 14, 2023 16:12
@julieg18 julieg18 temporarily deployed to gatsby-theme-update-ban-1gtzhh November 15, 2023 13:54 Inactive
@julieg18 julieg18 merged commit 676ddd8 into main Nov 15, 2023
2 checks passed
@julieg18 julieg18 deleted the update-banner-for-vscode-product-hunt branch November 15, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jellebouwman jellebouwman jellebouwman left review comments

@mvshmakov mvshmakov mvshmakov left review comments

@jendefig jendefig jendefig approved these changes

@tapadipti tapadipti Awaiting requested review from tapadipti

@dberenbaum dberenbaum Awaiting requested review from dberenbaum

Assignees

@julieg18 julieg18

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@julieg18 @mvshmakov @jellebouwman @tapadipti @jendefig @yathomasi