Use SIGINT as the default signal in queue kill

[karajan1001]

fix: #8624

1. Add a new flag --force for queue kill
2. Make SIGINT to be the default option and SIGKILL to be with --force
3. Remove SIGINT blocking.
4. Add tests for queue kill

wait for iterative/dvc-task#101

• ❗ I have followed the Contributing to DVC checklist.

• 📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.

Thank you for the contribution - we'll try to review it as soon as possible. 🙏

[codecov]

Codecov Report

Base: 93.50% // Head: 93.50% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (268360c) compared to base (5f0b1ed).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #8657   +/-   ##
=======================================
  Coverage   93.50%   93.50%           
=======================================
  Files         457      457           
  Lines       36203    36207    +4     
  Branches     5244     5246    +2     
=======================================
+ Hits        33850    33854    +4     
  Misses       1845     1845           
  Partials      508      508           

Impacted Files	Coverage Δ
dvc/commands/queue/kill.py	100.00% <100.00%> (ø)
dvc/repo/experiments/queue/celery.py	85.49% <100.00%> (+0.11%)	⬆️
dvc/stage/run.py	94.04% <100.00%> (ø)
tests/unit/command/test_queue.py	100.00% <100.00%> (ø)
tests/unit/repo/experiments/queue/test_celery.py	96.42% <100.00%> (+0.03%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[pmrowla]

@karajan1001 there's merge conflicts in this PR, CI can't run until it's fixed

[pmrowla]

This LGTM, pending @dberenbaum review of the help/usage messages

[dberenbaum]

When I run dvc queue kill using https://github.com/iterative/vscode-dvc-demo, it hangs and prints an error in the terminal like:

$ Process _DaemonProcess-1:
Traceback (most recent call last):
  File "/Users/dave/miniforge3/envs/torch/lib/python3.10/multiprocessing/process.py", line 314, in _bootstrap
    self.run()
  File "/Users/dave/miniforge3/envs/torch/lib/python3.10/site-packages/dvc_task/proc/process.py", line 232, in run
    super().run()
  File "/Users/dave/miniforge3/envs/torch/lib/python3.10/multiprocessing/process.py", line 108, in run
    self._target(*self._args, **self._kwargs)
  File "/Users/dave/miniforge3/envs/torch/lib/python3.10/site-packages/dvc_task/proc/process.py", line 224, in _spawn
    with cls(*args, **kwargs):
  File "/Users/dave/miniforge3/envs/torch/lib/python3.10/site-packages/dvc_task/proc/process.py", line 103, in __exit__
    self.wait()
  File "/Users/dave/miniforge3/envs/torch/lib/python3.10/site-packages/dvc_task/proc/process.py", line 196, in wait
    self._proc.wait(timeout=timeout)
  File "/Users/dave/miniforge3/envs/torch/lib/python3.10/subprocess.py", line 1207, in wait
    return self._wait(timeout=timeout)
  File "/Users/dave/miniforge3/envs/torch/lib/python3.10/subprocess.py", line 1941, in _wait
    (pid, sts) = self._try_wait(0)
  File "/Users/dave/miniforge3/envs/torch/lib/python3.10/subprocess.py", line 1899, in _try_wait
    (pid, sts) = os.waitpid(self.pid, wait_flags)
KeyboardInterrupt

[karajan1001]

When I run dvc queue kill using https://github.com/iterative/vscode-dvc-demo, it hangs and prints an error in the terminal like:

$ Process _DaemonProcess-1:
Traceback (most recent call last):
  File "/Users/dave/miniforge3/envs/torch/lib/python3.10/multiprocessing/process.py", line 314, in _bootstrap
    self.run()
  File "/Users/dave/miniforge3/envs/torch/lib/python3.10/site-packages/dvc_task/proc/process.py", line 232, in run
    super().run()
  File "/Users/dave/miniforge3/envs/torch/lib/python3.10/multiprocessing/process.py", line 108, in run
    self._target(*self._args, **self._kwargs)
  File "/Users/dave/miniforge3/envs/torch/lib/python3.10/site-packages/dvc_task/proc/process.py", line 224, in _spawn
    with cls(*args, **kwargs):
  File "/Users/dave/miniforge3/envs/torch/lib/python3.10/site-packages/dvc_task/proc/process.py", line 103, in __exit__
    self.wait()
  File "/Users/dave/miniforge3/envs/torch/lib/python3.10/site-packages/dvc_task/proc/process.py", line 196, in wait
    self._proc.wait(timeout=timeout)
  File "/Users/dave/miniforge3/envs/torch/lib/python3.10/subprocess.py", line 1207, in wait
    return self._wait(timeout=timeout)
  File "/Users/dave/miniforge3/envs/torch/lib/python3.10/subprocess.py", line 1941, in _wait
    (pid, sts) = self._try_wait(0)
  File "/Users/dave/miniforge3/envs/torch/lib/python3.10/subprocess.py", line 1899, in _try_wait
    (pid, sts) = os.waitpid(self.pid, wait_flags)
KeyboardInterrupt

Need to suppress this error message in dvc-task, iterative/dvc-task#103

[dberenbaum]

@karajan1001 What is this change about?

[dberenbaum]

@karajan1001 If you can explain this change, I'm happy to approve. Thanks!

[karajan1001]

Actually not anything affected by this. I will undo this.

[dberenbaum]

@karajan1001 Since it's a small change and @pmrowla is away, I'm happy to review this one (or you could ask someone else on the team). LGTM except for one minor question.

[karajan1001]

@karajan1001 Since it's a small change and @pmrowla is away, I'm happy to review this one (or you could ask someone else on the team). LGTM except for one minor question.

@pmrowla had already approved it, we can focus on documents reviewing.

[dberenbaum]

Thanks @karajan1001! The help messages look good. See the one question I had in this PR.

[pmrowla]

@karajan1001 this has conflicts w/the queue stop --kill PR that was merged