Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a new method interrupt to send SIGINT to tasks #101

Merged
merged 1 commit into from
Dec 8, 2022
Merged

Add a new method interrupt to send SIGINT to tasks #101

merged 1 commit into from
Dec 8, 2022

Conversation

karajan1001
Copy link
Contributor

fix: #100
Required from dvc to stop the checkpoint during running.

  1. Add a new method interrupt to send SIGINT to tasks
  2. Modify the unit test for this new method.

@karajan1001 karajan1001 added the enhancement New feature or request label Dec 5, 2022
@karajan1001 karajan1001 requested a review from pmrowla December 5, 2022 03:39
@karajan1001 karajan1001 self-assigned this Dec 5, 2022
@karajan1001 karajan1001 mentioned this pull request Dec 5, 2022
Merged
2 tasks
@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2022 •
edited
Loading

Codecov Report

Base: 78.33% // Head: 78.22% // Decreases project coverage by -0.10% ⚠️

Coverage data is based on head (b9d90a1) compared to base (01b5843).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head b9d90a1 differs from pull request most recent head 33a3250. Consider uploading reports for the commit 33a3250 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #101      +/-   ##
==========================================
- Coverage   78.33%   78.22%   -0.11%     
==========================================
  Files          21       21              
  Lines         923      923              
  Branches      145      146       +1     
==========================================
- Hits          723      722       -1     
- Misses        174      175       +1     
  Partials       26       26
Impacted Files Coverage Δ
src/dvc_task/proc/manager.py 80.50% <100.00%> (+0.68%) ⬆️
tests/proc/test_manager.py 97.56% <100.00%> (-2.44%) ⬇️
src/dvc_task/worker/temporary.py 81.96% <0.00%> (+1.63%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@karajan1001 karajan1001 force-pushed the fix100 branch 2 times, most recently from ea15a58 to ca59f8d Compare December 5, 2022 04:10
pmrowla
pmrowla approved these changes Dec 5, 2022
View reviewed changes
Copy link
Contributor

@pmrowla pmrowla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@karajan1001 please check the pylint warnings on windows (you need to add the ignore case for sigkill on windows)

@karajan1001 karajan1001 force-pushed the fix100 branch 3 times, most recently from fe484ae to b3017f9 Compare December 5, 2022 05:00
pmrowla
pmrowla suggested changes Dec 5, 2022
View reviewed changes
Copy link
Contributor

@pmrowla pmrowla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

marking as changes requested after os.kill/os.killpg discussion

@karajan1001 karajan1001 changed the title Add a new method interrupt to send SIGINT to tasks [WIP] Add a new method interrupt to send SIGINT to tasks Dec 5, 2022
@karajan1001 karajan1001 requested a review from pmrowla December 8, 2022 08:53
@karajan1001
Copy link
Contributor Author

A problem is that Windows can't be group=False

@karajan1001
Add a new method interrupt to send SIGINT to tasks
33a3250 
fix: #100
Required from dvc to stop the checkpoint during running.

1. Add a new method interrupt to send SIGINT to tasks
2. Modify the unit test for this new method.
3. Add `group` option to `send_signal`, `kill`, `terminate`, `interrrupt`
@karajan1001 karajan1001 changed the title [WIP] Add a new method interrupt to send SIGINT to tasks Add a new method interrupt to send SIGINT to tasks Dec 8, 2022
@karajan1001 karajan1001 merged commit b5cc7d4 into main Dec 8, 2022
@karajan1001 karajan1001 deleted the fix100 branch December 8, 2022 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmrowla pmrowla pmrowla approved these changes

Assignees

@karajan1001 karajan1001

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a new method interrupt to send SIGINT to tasks.
3 participants
@karajan1001 @codecov-commenter @pmrowla