Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC data cloud: declutter test #1761

Merged
merged 1 commit into from
Mar 21, 2019
Merged

RFC data cloud: declutter test #1761

merged 1 commit into from
Mar 21, 2019

Conversation

pared
Copy link
Contributor

@pared pared commented Mar 21, 2019

No description provided.

@efiop
Copy link
Contributor

efiop commented Mar 21, 2019

@pared Could you provide more info on why you are changing that test please?

@pared
Copy link
Contributor Author

pared commented Mar 21, 2019

@efiop sure
This tests puprose is to check whether ther is proper log displayed upon change of stage file. However not all elements of this test are required to check that. We don't need adding FOO and using it as dependency in run step. I decided to remove it after I realized it actually is distubing during debugging, when test started failing during implementation of #1214

@efiop efiop merged commit c65495e into iterative:master Mar 21, 2019
@pared pared deleted the rfc_simplify_test branch April 3, 2019 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efiop efiop efiop approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pared @efiop