-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
checkpoints: flag to exp push
&& push
#6182
Comments
@efiop, Some analysis after looking into it.
Any suggestions for this? |
Can this be an argument to |
Given that this is a CI thing, it seems like maybe it should just be set through an env var? something like like |
Also note that for CML purposes, I think we will want both DVC cache and run-cache to be included with the automated |
|
I think there's a few potential issues:
The latter two could be automatically handled in the cml workflow, or they could be handled with |
In terms of "will this break git/github", this is not an issue, there's no real limit to the number of refs git can handle, and the server will automatically pack them as needed. But yes, it will inflate the number of exps that would show up when users use
These commits go into the CML PR once the run is completed, correct? At that point, it seems to me that the exp ref is no longer needed and can just be removed (it doesn't matter whether or not the PR has been merged yet, the PR is it's own git ref).
If PRs are being merged on the github side, github already provides the option to squash before merging |
Great, so it seems like all that's needed is a mechanism to delete the exp refs once the pr is ready? |
* Push running checkpoint to remote Fix #6182 * Update dvc/repo/experiments/executor/base.py Co-authored-by: Peter Rowlands (변기호) <[email protected]> * Get the branch name * Finish this PR 1. move env name to dvc/env.py. 2. add some tests for it. * Update after finally commit * Some problems found in the review 1. change the behavior of self remote 2. do not use string DVC_EXP_AUTO_PUSH 3. downgrade the logger level in auto push 4. use full branch ref * Update dvc/repo/experiments/executor/base.py Co-authored-by: Peter Rowlands (변기호) <[email protected]> * add a remote check before auto push * Split current one env into two * Rename DVC_EXP_CHECKPOINT_PUSH to DVC_EXP_AUTO_PUSH * value error * Remove getenv_bool switch to env2bool * Better on handling Dulwich exceptions * Name changing removing prints * Update dvc/env.py Co-authored-by: Peter Rowlands (변기호) <[email protected]> * Some changes in review * Add validation to repo URL * Add new type of SCMError * Update dvc/repo/experiments/executor/base.py Co-authored-by: Peter Rowlands (변기호) <[email protected]> * Use spy tests call counts and args * Update dvc/scm/git/backend/base.py Co-authored-by: Peter Rowlands (변기호) <[email protected]> * Update dvc/scm/git/backend/dulwich.py Co-authored-by: Peter Rowlands (변기호) <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Remove validate_git_repo to validate_git_remote Co-authored-by: Peter Rowlands (변기호) <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Provide a flag (e.g.
dvclive.next_step(push=True)
ormake_checkpoint(push=True)
orDVC_EXP_AUTO_PUSH=<git_remote_name_or_url|true>
) to push things per-checkpoint.Helps with resuming a long-running CI job after timeout.
Part of iterative/cml#560.
The text was updated successfully, but these errors were encountered: