Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checkpoints: write dvc.lock on every checkpoint #6180

Closed
casperdcl opened this issue Jun 15, 2021 · 2 comments
Closed

checkpoints: write dvc.lock on every checkpoint #6180

casperdcl opened this issue Jun 15, 2021 · 2 comments
Labels
enhancement Enhances DVC feature request Requesting a new feature product: VSCode Integration with VSCode extension

Comments

@casperdcl
Copy link
Contributor

casperdcl commented Jun 15, 2021

(Over)writing dvc.lock after each checkpoint (so interrupting exp run will mean a usable dvc.lock is present).

Part of iterative/cml#560

@casperdcl casperdcl added enhancement Enhances DVC feature request Requesting a new feature product: VSCode Integration with VSCode extension labels Jun 15, 2021
@efiop efiop changed the title checkpoints: write dvc.lock checkpoints: write dvc.lock on every checkpoint Jun 15, 2021
@pmrowla
Copy link
Contributor

pmrowla commented Jun 16, 2021

Just to be clear here, dvc.lock should already be written (updated) at each checkpoint. We should also already be automatically tracking it in git for checkpoints as well. If you're seeing exp/checkpoint commits without dvc.lock files, it sounds like this is a bug somewhere in DVC

@casperdcl
Copy link
Contributor Author

There may be a bug here but it's low priority if #6182 is solved, so closing for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhances DVC feature request Requesting a new feature product: VSCode Integration with VSCode extension
Projects
None yet
Development

No branches or pull requests

2 participants