Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config to enable/disable updater #1894

Closed
mdscruggs opened this issue Apr 15, 2019 · 8 comments · Fixed by #4334
Closed

Config to enable/disable updater #1894

mdscruggs opened this issue Apr 15, 2019 · 8 comments · Fixed by #4334
Labels
feature request Requesting a new feature good first issue help wanted p3-nice-to-have It should be done this or next sprint ui user interface / interaction

Comments

@mdscruggs
Copy link

It'd be great if we could disable the updater feature via dvc config. It's rather noisy due to the frequent release cycle of DVC.

@shcheklein
Copy link
Member

@mdscruggs I think it's dangerous to disable it completely. We can find some middle ground here. What do you think if we introduce a notion of critical updates? For example, we know that there is a critical patch that fixes a certain version. We can detect the version running and notify only of versions match. I would notify at least once in a few days about minor version change anyways.

@mdscruggs
Copy link
Author

mdscruggs commented Apr 17, 2019

Any means to make the updater less noisy would be helpful, even if it still runs @shcheklein. The fast pace of DVC releases means it is effectively alerting us every few days...

While it is healthy to encourage users to update due to bug fixes and new features, users shouldn't feel pressured into updating constantly.

Even pip itself has a configuration setting for this, and releases far less frequently than DVC:

https://pip.pypa.io/en/stable/reference/pip/#cmdoption-disable-pip-version-check

pip also limits its check to weekly:

https://github.com/pypa/pip/blob/62cfaf0fc7efd4dfb67f100e08a2d07d8218eeaa/src/pip/_internal/utils/outdated.py#L98

@shcheklein
Copy link
Member

Ok, how about this plan:

  1. we introduce a config option to alter the interval (default is once a day)
  2. we introduce a mechanism to notify about critical updates (support a list of versions affected on the updater side, emphasize the message on the DVC side, etc).

would it suffice?

I really wan to avoid turning it off completely. It's dangerous because we are dealing with data here.

@mdscruggs
Copy link
Author

That sounds good @shcheklein.

Users who must or want to stabilize on a specific release of DVC should be able to do so without excessive alerting.

@Suor
Copy link
Contributor

Suor commented May 22, 2019

So updater will still be run each time to check if there are critical updates? No possibility to make it rest at all?

@shcheklein
Copy link
Member

@Suor is there a case in which users would not want to know about an update that potentially fixes a problem that can lead to data loss? We can give an option to disable it completely, and probably should do this, but we should emphasize that you are at risk when you are doing so, and it should be a second or third option after you have tuned the interval first.

@jorgeorpinel
Copy link
Contributor

we introduce a mechanism to notify about critical updates (support a list of versions affected on the updater side, emphasize the message on the DVC side, etc).

Where and how could this be implemented? Seems rather advanced, not sure this is a "good first issue", as currently labeled. But I also don't know how the updater works now, maybe it's quite simple?

@efiop
Copy link
Contributor

efiop commented Sep 27, 2019

@jorgeorpinel 1st step is to alter the interval. We could think about critical updates later.

@efiop efiop added p3-nice-to-have It should be done this or next sprint and removed p4 labels Sep 30, 2019
PuneethaPai added a commit to PuneethaPai/dvc that referenced this issue Aug 4, 2020
efiop pushed a commit that referenced this issue Aug 10, 2020
* Updater: Add method to check dvc core config check_update

* Updater: check config before calling update._check

Fixes #1894
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Requesting a new feature good first issue help wanted p3-nice-to-have It should be done this or next sprint ui user interface / interaction
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants