-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config to enable/disable updater #1894
Comments
@mdscruggs I think it's dangerous to disable it completely. We can find some middle ground here. What do you think if we introduce a notion of critical updates? For example, we know that there is a critical patch that fixes a certain version. We can detect the version running and notify only of versions match. I would notify at least once in a few days about minor version change anyways. |
Any means to make the updater less noisy would be helpful, even if it still runs @shcheklein. The fast pace of DVC releases means it is effectively alerting us every few days... While it is healthy to encourage users to update due to bug fixes and new features, users shouldn't feel pressured into updating constantly. Even https://pip.pypa.io/en/stable/reference/pip/#cmdoption-disable-pip-version-check
|
Ok, how about this plan:
would it suffice? I really wan to avoid turning it off completely. It's dangerous because we are dealing with data here. |
That sounds good @shcheklein. Users who must or want to stabilize on a specific release of DVC should be able to do so without excessive alerting. |
So updater will still be run each time to check if there are critical updates? No possibility to make it rest at all? |
@Suor is there a case in which users would not want to know about an update that potentially fixes a problem that can lead to data loss? We can give an option to disable it completely, and probably should do this, but we should emphasize that you are at risk when you are doing so, and it should be a second or third option after you have tuned the interval first. |
Where and how could this be implemented? Seems rather advanced, not sure this is a "good first issue", as currently labeled. But I also don't know how the updater works now, maybe it's quite simple? |
@jorgeorpinel 1st step is to alter the interval. We could think about critical updates later. |
* Updater: Add method to check dvc core config check_update * Updater: check config before calling update._check Fixes #1894
It'd be great if we could disable the updater feature via
dvc config
. It's rather noisy due to the frequent release cycle of DVC.The text was updated successfully, but these errors were encountered: