Updater: check config before calling update._check

Fixes iterative#1894
PuneethaPai · Aug 4, 2020 · 755e757 · 755e757
1 parent 9c09075
commit 755e757
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/dvc/updater.py b/dvc/updater.py
@@ -47,7 +47,12 @@ def _with_lock(self, func, action):
             logger.debug(msg.format(self.lock.lockfile, action))
 
     def check(self):
-        if os.getenv("CI") or env2bool("DVC_TEST") or PKG == "snap":
+        if (
+            os.getenv("CI")
+            or env2bool("DVC_TEST")
+            or PKG == "snap"
+            or not self.is_enabled()
+        ):
             return
 
         self._with_lock(self._check, "checking")

diff --git a/tests/unit/test_updater.py b/tests/unit/test_updater.py
@@ -58,6 +58,14 @@ def test_is_enabled(dvc, updater, core, result):
     assert result == updater.is_enabled()
 
 
+@pytest.mark.parametrize("result", [True, False])
+@mock.patch("dvc.updater.Updater._check")
+def test_check_update_respect_config(mock_check, result, updater, mocker):
+    mocker.patch.object(updater, "is_enabled", return_value=result)
+    updater.check()
+    assert result == mock_check.called
+
+
 @pytest.mark.parametrize(
     "current,latest,notify",
     [