Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Duplicated paging info to exp show #3310

Merged
merged 2 commits into from
Mar 14, 2022
Merged

Conversation

iesahin
Copy link
Contributor

@iesahin iesahin commented Feb 22, 2022

It was referencing dvc dag for paging info. Now it's self contained and added an example to use cat as a pager.

Closes #3217

@shcheklein shcheklein temporarily deployed to dvc-org-iesahin-issue-3-izobby February 22, 2022 15:44 Inactive
Comment on lines 76 to 77

> Note that this also applies to `dvc dag`.
Copy link
Contributor

@jorgeorpinel jorgeorpinel Feb 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't need this link or the link from dag to here since we're duplicating the content.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

Comment on lines 95 to 101

If you'd like to print to stdout always without paging, you can set this
variable to `cat`:

```dvc
$ export DVC_PAGER=cat
```
Copy link
Contributor

@jorgeorpinel jorgeorpinel Feb 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not further expand on Linux methods? There are others but this doc should be about DVC IMO.

Also, this isn't in https://dvc.org/doc/command-reference/dag#providing-a-custom-pager.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whole environment variable thing is about Linux. The method provides a way to skip the --no-pager option everytime. So I think it's a useful tip.

Copy link
Contributor

@jorgeorpinel jorgeorpinel Mar 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey sorry for the delay...

We can improve the env var blocks later to include Windows Cmd (Windows also supports the same env vars I think).

This is a cmd ref, we want it to be more focused/shorter/self contained I think. Again, this note is a Linux admin tip.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can improve the env var blocks later to include Windows Cmd

I'm making it clearer that these are Linux examples instead for now. See #3356

@shcheklein shcheklein temporarily deployed to dvc-org-iesahin-issue-3-izobby March 14, 2022 12:06 Inactive
@jorgeorpinel jorgeorpinel merged commit 9710b75 into master Mar 14, 2022
@jorgeorpinel jorgeorpinel deleted the iesahin/issue-3217 branch March 14, 2022 19:57
iesahin added a commit that referenced this pull request Apr 11, 2022
* duplicated paging info to `dvc exp show`

* revised per review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ref: include pagination info (less/more) in both dag and exp show
3 participants