Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: include pagination info (less/more) in both dag and exp show #3217

Closed
iesahin opened this issue Jan 26, 2022 · 7 comments · Fixed by #3310
Closed

ref: include pagination info (less/more) in both dag and exp show #3217

iesahin opened this issue Jan 26, 2022 · 7 comments · Fixed by #3310
Labels
A: docs Area: user documentation (gatsby-theme-iterative) C: ref Content of /doc/*-reference

Comments

@iesahin
Copy link
Contributor

iesahin commented Jan 26, 2022

The dvc dag reference has a section about setting the pager something other than less. This information applies to all commands that use pager, and better to be served elsewhere.

Possible candidates:

  • How-To (A dedicated page to specify pager for commands.)
  • User's Guide
@iesahin iesahin added A: docs Area: user documentation (gatsby-theme-iterative) C: guide Content of /doc/user-guide C: ref Content of /doc/*-reference labels Jan 26, 2022
@shcheklein
Copy link
Member

Sounds good. Could we though list first what other commands are affected by this?

@iesahin
Copy link
Contributor Author

iesahin commented Jan 27, 2022

Probably only dvc dag and dvc exp show but I'm searching them.

@jorgeorpinel
Copy link
Contributor

If it's just those 2 maybe repeat the pagination paragraph on both for now. Until we have a proper config guide (#340) at least

@iesahin
Copy link
Contributor Author

iesahin commented Jan 31, 2022

dvc exp show also has a --no-pager flag. I'm not sure if takes DVC_PAGER into consideration, I need to test this first.

@iesahin
Copy link
Contributor Author

iesahin commented Feb 1, 2022

It looks dvc exp show takes both --no-pager and DVC_PAGER into consideration.

image

@jorgeorpinel
Copy link
Contributor

OK so again if it's just those 2 references, let's keep the info in them even if it's slightly repetitive, I think. Sounds like It won't be exactly the same anyway.

@iesahin
Copy link
Contributor Author

iesahin commented Feb 10, 2022

I thought other commands are using the variable, it looks not so. I agree with you to keep them same way.

@jorgeorpinel jorgeorpinel changed the title ref: Move pagination (less/more) section to elsewhere from dvc dag ref: include pagination info (less/more) in both dag and exp show Feb 10, 2022
@jorgeorpinel jorgeorpinel removed the C: guide Content of /doc/user-guide label Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: docs Area: user documentation (gatsby-theme-iterative) C: ref Content of /doc/*-reference
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants