-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Fix #313 #330
[WIP] Fix #313 #330
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kurianbenoy it should be done in a way that does not require inserting additional statements inside code blocks. Actually, we should remove extra leading whitespaces after this ticket is closed. I think that you would need to modify the src/Documentation/Markdown/Markdown.js
line 61, CodeBlock
renderer.
@shcheklein I guess the change I made in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a comment on how should we be applying the padding. Agreed on trying it on the get started first.
I have incorporated the changes you suggested. |
@kurianbenoy check the deployment: It looks like 2em should be enough. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check the comments, check the deployment. It looks like 2em should be enough.
I feel it should have been better to use 3 or 4 em to be as aligned to current docs |
@kurianbenoy yep, 3em looks like a good option. We def don't need more. |
@kurianbenoy actually, even 2em is enough ) Up to you, 2em or 3em :) |
Ok let's stick to 2em then @shcheklein |
@algomaster99 @jorgeorpinel I'm going to merge this. Just keep in mind guys, that we don't need spaces any more. @algomaster99 when you run the prettier next time (if we can figure out all the caveats with it), please, make sure that it removes all spaces everywhere. @kurianbenoy thank you! :) |
@shcheklein all the spaces should be removed inside code blocks know? There should be no indentation right? |
@algomaster99 correct! no need for the manual indentation anymore. @kurianbenoy already did this across the get started section. Would be great if @kurianbenoy let's first wait on @algomaster99 if it can be done automatically. If |
@ivan I have been thinking about using css padding by calling a html element like this:
with .intent having property padding-left:4em as css attribute.
I am not familiar with React, so I am not sure, what is correct change to be done there. Yet I hope this approach work, as its done for tag in docs.
Thanks