Add pre-commit hook instructions to contribution documentation guide #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shcheklein
reviewed
May 13, 2019
| ```dvc | ||
| $ cd dvc.org | ||
| $ virtualenv --python python3 .env | ||
| $ source .env/bin/activate |
There was a problem hiding this comment.
minor: 4 spaces inside the code blocks
algomaster99
force-pushed
the
contribution-documentation-pre-commit
branch
from
4619e09 to
700e948
Compare
|
@shcheklein Currently, I have removed manual indentation in code blocks since pull request has been merged. I had to do it manually because prettier was unable to format it. I have opened an issue for it in their repository. |
shcheklein
reviewed
May 14, 2019
shcheklein
approved these changes
May 14, 2019
|
Let's wait on your investigation of the second PR before we do this merge. It might change a little bit. |
|
@shcheklein yeah let's wait for prettier to respond on this issue. 😅 |
|
@algomaster99 please review it again after I merged your prettier PR, resolve the conflict and let's merge it again. |
algomaster99
force-pushed
the
contribution-documentation-pre-commit
branch
from
74a87a0 to
449bfcc
Compare
|
@shcheklein Please see this. I think it is ready for merge. If there are more changes, let me know. |
shcheklein
approved these changes
May 15, 2019
|
thanks @algomaster99 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add instructions to setup pre-commit hook as added in this pull request.