Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start: use tabs for a Windows command #3215

Merged
merged 6 commits into from
Feb 11, 2022
Merged

start: use tabs for a Windows command #3215

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0348b43
Changed line 168 ~ from rm -f data/... to rm -Force data/...
mahnoor-shahid Jan 26, 2022
c36aab1
Apply suggestions from code review
jorgeorpinel Feb 2, 2022
eba493b
Update content/docs/start/data-and-model-versioning.md
jorgeorpinel Feb 2, 2022
c9fe38e
Update content/docs/start/data-and-model-versioning.md
jorgeorpinel Feb 2, 2022
1e2b1df
Update content/docs/start/data-and-model-versioning.md
jorgeorpinel Feb 2, 2022
681479a
Update content/docs/start/data-and-model-versioning.md
jorgeorpinel Feb 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions content/docs/start/data-and-model-versioning.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,11 +163,24 @@ run it after `git clone` and `git pull`.
If you've run `dvc push`, you can delete the cache (`.dvc/cache`) and
`data/data.xml` to experiment with `dvc pull`:

<toggle>
<tab title="Mac/Linux">

```dvc
$ rm -rf .dvc/cache
jorgeorpinel marked this conversation as resolved.
Show resolved Hide resolved
$ rm -f data/data.xml
```

</tab>
<tab title="Windows">

```
> del data\data.xml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Separate question: Prism doesn't seem to have a Windows Command Prompt language unfortunately. It does have PowerShell but I assume we're going with plain cmd right @shcheklein ? If so we may need to make a new custom highlighter cc @julieg18 WDYT

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jorgeorpinel I don't think we need a custom highlighter since I think PowerShell runs Windows Command Prompt language as well as its own special syntax. Using the powershell language should suffice.

How this script would look in powershell using Prism's Test drive tool:

image

Copy link
Contributor

@jorgeorpinel jorgeorpinel Feb 11, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call @julieg18 ! But in any case the reason we have the dvc highlighter is to highlight dvc {something} commands... So we may need to eventually move that to dvc-posix and make a new dvc-win one, perhaps based of powershell?

We can continue to discuss in #3273

jorgeorpinel marked this conversation as resolved.
Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about powershell - it it del or does it support Posix?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with PowerShell but it looks like it's a totally different command: Remove-Item.

```
jorgeorpinel marked this conversation as resolved.
Show resolved Hide resolved

</tab>
</toggle>

</details>

```dvc
Expand Down