Fix sidebar support for empty links (/doc/ trailing slash issue) #1265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a hard-coded `/doc/` prepended to every path before, but now we start with `/doc` and add a second slash only if something comes after.
jorgeorpinel
approved these changes
May 8, 2020
There was a problem hiding this comment.
Thanks @rogermparent! This seems to fix it, at least what I reported in #1257 (comment)
shcheklein
approved these changes
May 8, 2020
|
thanks @rogermparent 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a hard-coded
/doc/prepended to every path before, but now we startwith
/docand add a second slash only if something comes after.This is a quick fix, but this problem stems from the
sidebar.jsonsetup still having influence in many places of the site. Ideally it should be just be the canonical ToC and have nothing to do with link generation, but that's a problem for another time.fixes #1264