Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with trailing slashes on the new docs path #1264

Closed
rogermparent opened this issue May 8, 2020 · 1 comment · Fixed by #1265
Closed

Problems with trailing slashes on the new docs path #1264

rogermparent opened this issue May 8, 2020 · 1 comment · Fixed by #1265
Assignees
Labels
A: website Area: website good first issue Good for newcomers 🐛 type: bug Something isn't working. website: eng-doc DEPRECATED JS engine for /doc

Comments

@rogermparent
Copy link
Contributor

rogermparent commented May 8, 2020

For some reason, at some point after #1257, trailing slashes appear in the hrefs of links pointing to the new homepage at "/doc", but inconsistently as the effect is removed upon navigation.

This issue is to investigate and fix that.

@rogermparent rogermparent added 🐛 type: bug Something isn't working. p0-critical Affects users in a bad way at the moment A: website Area: website labels May 8, 2020
@rogermparent
Copy link
Contributor Author

rogermparent commented May 8, 2020

From my investigation so far, it seems to be related to the sidebar which hasn't actually been completely decoupled from link logic. The normalized sidebar has the doc page as /doc/ despite everything else, even the internal Gatsby node, having no trailing slash.
This issue alone shouldn't be too hard to patch up quickly, but it indicates we're in need of a bigger fix to actually separate this sidebar or re-integrate it in a better way. That said, that fix should be another issue and this one should just fix the problem in front of us now.

@rogermparent rogermparent self-assigned this May 8, 2020
@jorgeorpinel jorgeorpinel added good first issue Good for newcomers website: eng-doc DEPRECATED JS engine for /doc and removed p0-critical Affects users in a bad way at the moment labels May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: website Area: website good first issue Good for newcomers 🐛 type: bug Something isn't working. website: eng-doc DEPRECATED JS engine for /doc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants