Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change tag page paths to be under /blog #1261

Merged
merged 1 commit into from
May 7, 2020
Merged

Conversation

rogermparent
Copy link
Contributor

Also change existing links to tag pages to use this new format

Fixes #1222, disregarding the question about RSS because we don't currently use tags in the RSS feed. We could add them somehow, but that's another issue.

Also change existing links to tag pages to use this new format
@shcheklein shcheklein temporarily deployed to dvc-landing-change-blog-c9fwhp May 7, 2020 21:19 Inactive
@rogermparent
Copy link
Contributor Author

rogermparent commented May 7, 2020

yarn run v1.22.4
$ ./scripts/link-check-git-diff.sh
~/repo ~/repo
content/blog/2020-04-06-april-20-dvc-heartbeat.md:/dev/fd/63:
 ERROR:404:https://dvc.org/blog/tags/heartbeat
ERROR:1 failures
---
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Exited with code exit status 1

Looks like the CI test is failing on a link in the content which points to the prod site, so it fails on this branch because it's looking for the new tag page that won't exist until this hits prod.

@rogermparent rogermparent self-assigned this May 7, 2020
@shcheklein shcheklein merged commit 43e090b into master May 7, 2020
@shcheklein shcheklein deleted the change-blog-tag-paths branch February 28, 2021 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

blog: tags URL should be under blog prefix
2 participants