Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blog: tags URL should be under blog prefix #1222

Closed
2 tasks
shcheklein opened this issue May 3, 2020 · 1 comment · Fixed by #1261
Closed
2 tasks

blog: tags URL should be under blog prefix #1222

shcheklein opened this issue May 3, 2020 · 1 comment · Fixed by #1261
Assignees
@rogermparent
Labels
A: website Area: website C: blog TEMPORARY Content of /blog p1-important Active priorities to deal within next sprints 🐛 type: bug Something isn't working. website: eng-blog DEPRECATED JS engine for /blog

Comments

@shcheklein
Copy link
Member

shcheklein commented May 3, 2020 •
edited
Loading

https://dvc.org/tags/heartbeat -> https://dvc.org/blog/tags/heartbeat

  • Don't forget to update existing links
  • Check RSS (do we have it/need for tags?)
@shcheklein shcheklein added website: eng-blog DEPRECATED JS engine for /blog 🐛 type: bug Something isn't working. p1-important Active priorities to deal within next sprints labels May 3, 2020
@shcheklein shcheklein changed the title tags URL should be under blog prefix blog: tags URL should be under blog prefix May 3, 2020
@shcheklein shcheklein added the A: website Area: website label May 7, 2020
@rogermparent rogermparent self-assigned this May 7, 2020
@rogermparent rogermparent mentioned this issue May 7, 2020
Merged
@rogermparent
Copy link
Contributor

I ripgrepped for tag/ and changed everything that matches to blog/tag/, which should take care of existing content.
We currently don't use tag data for any feeds, and I'd say adding tags to feeds would warrant another issue entirely.

@weekly-digest weekly-digest bot mentioned this issue May 10, 2020
Closed
@iesahin iesahin added the C: blog TEMPORARY Content of /blog label Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rogermparent rogermparent

Labels
A: website Area: website C: blog TEMPORARY Content of /blog p1-important Active priorities to deal within next sprints 🐛 type: bug Something isn't working. website: eng-blog DEPRECATED JS engine for /blog
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change tag page paths to be under /blog iterative/dvc.org
3 participants
@iesahin @shcheklein @rogermparent