Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change gitpod button to HTML link #1251

Merged
merged 2 commits into from
May 6, 2020
Merged

Change gitpod button to HTML link #1251

merged 2 commits into from
May 6, 2020

Conversation

rogermparent
Copy link
Contributor

@rogermparent rogermparent commented May 6, 2020 •
edited by jorgeorpinel
Loading

This is a workaround to skip the automatic "external" icon appended to normal links in docs MD.

Fixes? #1246

@rogermparent
Change gitpod button to HTML link
c4751b8 
This is a workaround to skip the automatic "external" icon appended to normal
links in docs MD.
@shcheklein shcheklein temporarily deployed to dvc-landing-external-li-y4p4ls May 6, 2020 00:32 Inactive
@rogermparent rogermparent mentioned this pull request May 6, 2020
Closed
jorgeorpinel
jorgeorpinel previously approved these changes May 6, 2020
View reviewed changes
Copy link
Contributor

@jorgeorpinel jorgeorpinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. This is an easy workaround indeed. I guess it's fine since we only have one instance 🙂

Thanks

@jorgeorpinel jorgeorpinel dismissed their stale review May 6, 2020 02:19

Actually...

@rogermparent rogermparent temporarily deployed to dvc-landing-external-li-y4p4ls May 6, 2020 02:47 Inactive
@jorgeorpinel jorgeorpinel merged commit b8cd773 into master May 6, 2020
@jorgeorpinel
Copy link
Contributor

Noice. This doesn't close #1246 because Ivan has a question in #1246 (comment). Let's close it (or not) manually.

@weekly-digest weekly-digest bot mentioned this pull request May 10, 2020
Closed
@shcheklein shcheklein deleted the external-link-button-workaround branch February 28, 2021 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgeorpinel jorgeorpinel jorgeorpinel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rogermparent @jorgeorpinel @shcheklein