Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

links: option to prevent external icon (for images e.g. buttons) #1246

Closed
jorgeorpinel opened this issue May 5, 2020 · 5 comments
Closed
Labels
A: website Area: website good first issue Good for newcomers type: enhancement Something is not clear, small updates, improvement suggestions website: eng-doc DEPRECATED JS engine for /doc

Comments

@jorgeorpinel
Copy link
Contributor

To prevent this:

image

From https://dvc.org/doc/user-guide/contributing/docs#development-environment

@jorgeorpinel jorgeorpinel added type: enhancement Something is not clear, small updates, improvement suggestions good first issue Good for newcomers website: eng-doc DEPRECATED JS engine for /doc labels May 5, 2020
@rogermparent
Copy link
Contributor

You can work around this issue by making a link in explicit HTML instead of Markdown. I have a PR showing how it can fix this issue at #1251

@shcheklein
Copy link
Member

@rogermparent does it makes sense to keep the ticket open even if we apply workaround? Can we detect this type of links automatically?

@shcheklein shcheklein added the A: website Area: website label May 6, 2020
@jorgeorpinel
Copy link
Contributor Author

If that's not easy, I think we can close this. We're using the workaround for now.

@rogermparent
Copy link
Contributor

rogermparent commented May 6, 2020

It shouldn't be too hard to simply give this a real implementation, but the question is how we do so. If we change it such that external links containing only an image are exempt, do we need to implement the behavior to re-enable the link?

I don't think this issue is anything to worry about currently with the workaround, but is worth bringing up as a concern if at any point we overhaul the blog remark pipeline.

I'd say close this issue and maybe open a new one when we get a few more instances of this.

@jorgeorpinel
Copy link
Contributor Author

Thanks for looking into it Roger. Sounds complicated, I think let's close this for now but feel free to reopen if you feel differently, guys.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: website Area: website good first issue Good for newcomers type: enhancement Something is not clear, small updates, improvement suggestions website: eng-doc DEPRECATED JS engine for /doc
Projects
None yet
Development

No branches or pull requests

3 participants