Change comment proxy cache TTL to 1 minute #1250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not certain that we should do this, but this is the fix for #1232.
The cache could be at 15 minutes currently for a good reason (does @fabiosantoscode know?), but I'm not aware of any discourse cache limits, and we don't have an API key here so I can't see how it would track usage to do any throttling.
I personally think the comment count being delayed on the website isn't much of an issue that actually impacts users, but that's not for me to decide and this looks like a simple fix.
If somehow cache is living past the specified TTL, this deploy preview can still be useful considering its TTL is one minute as opposed to master's 15. I'm not familiar with Discourse and how to use it so I haven't run a test yet, but I can try it.