Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blog: "number of comments" cache is too aggressive #1232

Closed
shcheklein opened this issue May 4, 2020 · 4 comments
Closed

blog: "number of comments" cache is too aggressive #1232

shcheklein opened this issue May 4, 2020 · 4 comments
Labels
A: website Area: website C: blog TEMPORARY Content of /blog p0-critical Affects users in a bad way at the moment website: eng-blog DEPRECATED JS engine for /blog

Comments

@shcheklein
Copy link
Member

shcheklein commented May 4, 2020 •
edited
Loading

Caching is too aggressive. It should be around 1 minute at most (?). Right now it takes too long to wait to see the new value.

(it might be even that we don't reset it until the redeploy)
@shcheklein shcheklein added A: website Area: website p2-nice-to-have Less of a priority at the moment. We don't usually deal with this immediately. website: eng-blog DEPRECATED JS engine for /blog p1-important Active priorities to deal within next sprints and removed p2-nice-to-have Less of a priority at the moment. We don't usually deal with this immediately. labels May 4, 2020
@shcheklein
Copy link
Member Author

shcheklein commented May 4, 2020 •
edited
Loading

Making it p0 to at least check that we don't cache it infinitely. That would be a major p-0.

@shcheklein shcheklein added p0-critical Affects users in a bad way at the moment and removed p1-important Active priorities to deal within next sprints labels May 4, 2020
@rogermparent
Copy link
Contributor

rogermparent commented May 4, 2020 •
edited
Loading

Looks like it's 900s (15m) right now, as seen here

@shcheklein
Copy link
Member Author

Let's test it on one of the older posts? to make sure that redeploy is not required at least

@shcheklein shcheklein changed the title blog: number of comments cache is too aggressive blog: "number of comments" cache is too aggressive May 4, 2020
@rogermparent rogermparent mentioned this issue May 5, 2020
Merged
@shcheklein
Copy link
Member Author

Fixed by #1250

@weekly-digest weekly-digest bot mentioned this issue May 10, 2020
Closed
@iesahin iesahin added the C: blog TEMPORARY Content of /blog label Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A: website Area: website C: blog TEMPORARY Content of /blog p0-critical Affects users in a bad way at the moment website: eng-blog DEPRECATED JS engine for /blog
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@iesahin @shcheklein @rogermparent