Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update to NodeJS==16 #783

Merged
merged 6 commits into from
Nov 12, 2021
Merged

update to NodeJS==16 #783

merged 6 commits into from
Nov 12, 2021

Conversation

casperdcl
Copy link
Contributor

@casperdcl casperdcl commented Oct 27, 2021 •
edited
Loading

@casperdcl casperdcl added technical-debt Refactoring, linting & tidying dependencies labels Oct 27, 2021
@casperdcl casperdcl self-assigned this Oct 27, 2021
@casperdcl casperdcl temporarily deployed to internal October 27, 2021 10:14 Inactive
DavidGOrtega
DavidGOrtega previously requested changes Oct 27, 2021
View reviewed changes
package.json Show resolved Hide resolved
@DavidGOrtega DavidGOrtega mentioned this pull request Oct 27, 2021
Closed
@DavidGOrtega
Copy link
Contributor

Aside the author looks good to me. I have prepared a PR to fix the lint issues #784 :)

@casperdcl casperdcl temporarily deployed to internal October 27, 2021 10:52 Inactive
casperdcl
casperdcl commented Oct 27, 2021
View reviewed changes
.eslintrc.js Show resolved Hide resolved
@casperdcl
Copy link
Contributor Author

Aside the author looks good to me. I have prepared a PR to fix the lint issues #784 :)

ah srry didn't see #784 :D

@casperdcl casperdcl temporarily deployed to internal October 27, 2021 15:49 Inactive
@casperdcl casperdcl temporarily deployed to internal October 27, 2021 17:53 Inactive
@casperdcl casperdcl temporarily deployed to internal October 27, 2021 18:01 Inactive
@DavidGOrtega
Copy link
Contributor

DavidGOrtega commented Oct 28, 2021 •
edited
Loading

Test are not passing @casperdcl #784 did

@casperdcl
Copy link
Contributor Author

casperdcl commented Oct 28, 2021 •
edited
Loading

Yes but #785 (https://github.com/iterative/cml/actions/runs/1394058565) isn't passing either, I assume related to #776 (comment)

@casperdcl casperdcl mentioned this pull request Oct 28, 2021
Closed
@casperdcl casperdcl temporarily deployed to internal October 28, 2021 17:13 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal October 28, 2021 17:22 Inactive
@0x2b3bfa0
Copy link
Member

@casperdcl, c69eb2f to avoid a warning and, potentially, some hard to debug issues.

@casperdcl
bump deps
9d999be 
- closes #767
- closes #771
- closes #774
- closes #775
@casperdcl casperdcl temporarily deployed to internal October 28, 2021 17:35 Inactive
0x2b3bfa0
0x2b3bfa0 previously approved these changes Oct 28, 2021
View reviewed changes
@0x2b3bfa0 0x2b3bfa0 mentioned this pull request Oct 28, 2021
Closed
@0x2b3bfa0 0x2b3bfa0 linked an issue Oct 28, 2021 that may be closed by this pull request
Drop support for Node.js 12 or use a transpiler #597
Closed
@casperdcl casperdcl temporarily deployed to internal October 29, 2021 11:33 Inactive
@casperdcl casperdcl temporarily deployed to internal November 12, 2021 13:06 Inactive
@casperdcl casperdcl merged commit 64343e3 into master Nov 12, 2021
@casperdcl casperdcl deleted the nodejs-16 branch November 12, 2021 13:56
This was referenced Nov 12, 2021
Closed
Closed
Closed
Closed
@casperdcl casperdcl added the releases Shipping builds label Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidGOrtega DavidGOrtega DavidGOrtega left review comments

@0x2b3bfa0 0x2b3bfa0 0x2b3bfa0 approved these changes

Assignees

@casperdcl casperdcl

Labels
releases Shipping builds technical-debt Refactoring, linting & tidying
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop support for Node.js 12 or use a transpiler
3 participants
@casperdcl @DavidGOrtega @0x2b3bfa0