gitlab test failing: comment limit exceeded

[casperdcl]

vis. #785, #783, #776 (comment)

[DavidGOrtega]

closed via #782

Its the same @casperdcl if you still feel that its not feel free to reopen it

[0x2b3bfa0]

@DavidGOrtega, #785 (comment) is failing on the cloud GitLab tests, I think.

[0x2b3bfa0]

[DavidGOrtega]

Hold on.

Looks like its is a broken test

● Gitlab tests › Comment should succeed with a valid sha

we are not returning a valid sha anymore but a url

[casperdcl]

somehow https://github.com/iterative/cml/runs/4018794557?check_suite_focus=true passed though

[DavidGOrtega]

we are not returning a valid sha anymore but a url

I was wrong the comment confused me. Its OK and actually the tests passes locally

root@7237f3d0e3de:/iterative/cml2# npm run test -- src/cml.test.js 

> @dvcorg/[email protected] test /iterative/cml2
> jest --forceExit "src/cml.test.js"

Proxy listening on port 9093
 PASS  src/cml.test.js (35.282 s)
  Github tests
    ✓ driver has to be github (16 ms)
    ✓ Publish image without markdown returns an url (3113 ms)
    ✓ Publish image with markdown (1472 ms)
    ✓ Publish a non image file in markdown (1395 ms)
    ✓ Comment should succeed with a valid sha (1429 ms)
    ✓ Comment should fail with a invalid sha (2557 ms)
  Gitlab tests
    ✓ driver has to be gitlab (1 ms)
    ✓ Publish image using gl without markdown returns an url (3504 ms)
    ✓ Publish image using gl with markdown (3884 ms)
    ✓ Publish a non image file using gl in markdown (2871 ms)
    ✓ Publish a non image file using native (3392 ms)
    ✓ Publish should fail with an invalid driver (3 ms)
    ✓ Comment should succeed with a valid sha (2579 ms)
    ✓ Comment should fail with a invalid sha (1709 ms)

Test Suites: 1 passed, 1 total
Tests:       14 passed, 14 total
Snapshots:   0 total
Time:        35.744 s, estimated 41 s

[DavidGOrtega]

> @dvcorg/[email protected] test /iterative/cml2
> jest --forceExit "src/drivers/gitlab.test.js"

Proxy listening on port 9093
 PASS  src/drivers/gitlab.test.js (10.508 s)
  Non Enviromental tests
    ✓ test repo and token (3 ms)
    ✓ Comment (2599 ms)
    ✓ Check (15 ms)
    ✓ Publish (2410 ms)
    ✓ Runner token (1129 ms)

Test Suites: 1 passed, 1 total
Tests:       5 passed, 5 total
Snapshots:   0 total
Time:        10.891 s
Ran all test suites matching /src\/drivers\/gitlab.test.js/i.
Teardown Jest. Stoping Proxy...
Force exiting Jest: Have you considered using `--detectOpenHandles` to detect async operations that kept running after all tests finished?

[DavidGOrtega]

We have hit the max amount of comments

      {
        message: 'Failed to save note {:base=>["Maximum number of comments exceeded"]}'
      }

      at Gitlab.request (src/drivers/gitlab.js:368:40)

[DavidGOrtega]

@casperdcl @0x2b3bfa0 we have to change TEST_GITLAB_SHA to point f8b8b49a253243830ef59a7f090eb887157b2b67

I have already done it in GL

This is just a temp fix.