-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cml runner long job #583
Cml runner long job #583
Conversation
#208 is pending because:
The only solution (and actually the original one) is to control the timer to not reach the MAX GH timeout time and restart a few min before reach it. This would solve the max time limit in GH respecting every timeout defined by the users. What do you think? |
we should also maybe add an option (default |
I liked this idea and has been explored before but the runner needs to know the SHA. Aside that I think that what we should do is do proper logging #22 That way they could setup the logging config and being able to log everything and this would also be nice for DVC viewer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should be configurable (--retry-timeout
, similar to --idle-timeout
) - here's the gist...
@DavidGOrtega, do you want a release manager review? They're free this week! |
@0x2b3bfa0 please! |
496070a
to
eddeae9
Compare
1d6e728
to
3e6545f
Compare
Introduces restart all the workflows with jobs not yet finished.
success:
closes #174
closes #208 partially?