Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proxy support #674

Merged
merged 37 commits into from
Sep 13, 2021
Merged

Proxy support #674

merged 37 commits into from
Sep 13, 2021

Conversation

DavidGOrtega
Copy link
Contributor

@DavidGOrtega DavidGOrtega commented Jul 27, 2021 •
edited
Loading

Adds proxy support in drivers via well known env variables http_proxy and https_proxy

@DavidGOrtega DavidGOrtega temporarily deployed to internal July 27, 2021 15:16 Inactive
@DavidGOrtega
Copy link
Contributor Author

Jest teardown is working locally but not in the CI 🤔

@DavidGOrtega DavidGOrtega temporarily deployed to internal July 28, 2021 08:55 Inactive
@DavidGOrtega DavidGOrtega temporarily deployed to internal July 29, 2021 13:15 Inactive
@DavidGOrtega DavidGOrtega temporarily deployed to internal July 29, 2021 19:04 Inactive
@DavidGOrtega DavidGOrtega temporarily deployed to internal July 29, 2021 19:14 Inactive
@DavidGOrtega DavidGOrtega temporarily deployed to internal July 29, 2021 19:21 Inactive
@DavidGOrtega DavidGOrtega temporarily deployed to internal July 29, 2021 20:49 Inactive
@DavidGOrtega DavidGOrtega temporarily deployed to internal July 29, 2021 20:59 Inactive
@DavidGOrtega DavidGOrtega temporarily deployed to internal July 29, 2021 22:01 Inactive
casperdcl
casperdcl reviewed Aug 1, 2021
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
@DavidGOrtega DavidGOrtega marked this pull request as draft August 2, 2021 09:06
@DavidGOrtega DavidGOrtega temporarily deployed to internal August 2, 2021 11:54 Inactive
@DavidGOrtega DavidGOrtega temporarily deployed to internal August 2, 2021 12:04 Inactive
@DavidGOrtega DavidGOrtega marked this pull request as ready for review August 2, 2021 12:05
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal August 5, 2021 10:08 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal August 5, 2021 10:09 Inactive
0x2b3bfa0
0x2b3bfa0 approved these changes Aug 5, 2021
View reviewed changes
Copy link
Member

@0x2b3bfa0 0x2b3bfa0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 🎉

@0x2b3bfa0 0x2b3bfa0 added the enhancement New feature or request label Aug 5, 2021
@DavidGOrtega DavidGOrtega temporarily deployed to internal August 16, 2021 15:10 Inactive
@DavidGOrtega DavidGOrtega added the blocked Dependent on something else label Aug 16, 2021
@DavidGOrtega
Copy link
Contributor Author

DavidGOrtega commented Aug 16, 2021 •
edited
Loading

@casperdcl @0x2b3bfa0 blocked until #693 is merged

@DavidGOrtega DavidGOrtega temporarily deployed to internal August 16, 2021 15:19 Inactive
@DavidGOrtega DavidGOrtega temporarily deployed to internal August 16, 2021 15:55 Inactive
@DavidGOrtega DavidGOrtega temporarily deployed to internal August 16, 2021 16:01 Inactive
@DavidGOrtega DavidGOrtega temporarily deployed to internal August 16, 2021 16:01 Inactive
casperdcl
casperdcl reviewed Aug 16, 2021
View reviewed changes
package.json Outdated Show resolved Hide resolved
@DavidGOrtega DavidGOrtega marked this pull request as draft August 18, 2021 08:03
@casperdcl
Copy link
Contributor

are there issue(s) at https://github.com/facebook/jest/issues? For now could skip.

@0x2b3bfa0 @casperdcl
Run tests with global timeout
77c046b 
Co-authored-by: Casper da Costa-Luis <[email protected]>
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal September 2, 2021 11:28 Inactive
@DavidGOrtega DavidGOrtega temporarily deployed to internal September 13, 2021 10:31 Inactive
@DavidGOrtega DavidGOrtega temporarily deployed to internal September 13, 2021 10:34 Inactive
@DavidGOrtega DavidGOrtega temporarily deployed to internal September 13, 2021 11:10 Inactive
@DavidGOrtega DavidGOrtega temporarily deployed to internal September 13, 2021 11:31 Inactive
@DavidGOrtega DavidGOrtega temporarily deployed to internal September 13, 2021 11:38 Inactive
@DavidGOrtega DavidGOrtega removed the blocked Dependent on something else label Sep 13, 2021
@DavidGOrtega DavidGOrtega marked this pull request as ready for review September 13, 2021 11:45
@DavidGOrtega
Copy link
Contributor Author

@0x2b3bfa0 finally!!!! we can forget #694

@DavidGOrtega DavidGOrtega merged commit 4f7a5d9 into master Sep 13, 2021
@DavidGOrtega DavidGOrtega deleted the proxy branch September 13, 2021 12:26
@snyk-bot snyk-bot mentioned this pull request Sep 25, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x2b3bfa0 0x2b3bfa0 0x2b3bfa0 approved these changes

@casperdcl casperdcl casperdcl left review comments

Assignees

@DavidGOrtega DavidGOrtega

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tests hang forever Using CML behind a proxy
3 participants
@DavidGOrtega @casperdcl @0x2b3bfa0