Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Startup script #445

Merged
merged 3 commits into from
Mar 16, 2021
Merged

Startup script #445

merged 3 commits into from
Mar 16, 2021

Conversation

DavidGOrtega
Copy link
Contributor

Adds base64 startup script. This side was needed in order to fully support iterative/terraform-provider-iterative#74

@restyled-io restyled-io bot mentioned this pull request Mar 15, 2021
@0x2b3bfa0

This comment has been minimized.

@DavidGOrtega

This comment has been minimized.

@0x2b3bfa0

This comment has been minimized.

@DavidGOrtega

This comment has been minimized.

@DavidGOrtega DavidGOrtega changed the title Startup script wip - Startup script Mar 15, 2021
@DavidGOrtega DavidGOrtega changed the base branch from master to release/v0.3.1 March 15, 2021 12:31
@DavidGOrtega DavidGOrtega changed the title wip - Startup script Startup script Mar 15, 2021
@DavidGOrtega DavidGOrtega requested a review from 0x2b3bfa0 March 15, 2021 12:32
@0x2b3bfa0
Copy link
Member

0x2b3bfa0 commented Mar 15, 2021

@DavidGOrtega, can you please retry the GitLab job? I don't have enough permissions.

@DavidGOrtega
Copy link
Contributor Author

GL is still having issues

@DavidGOrtega
Copy link
Contributor Author

Anyway I think that its not going to pass, we dont have SG creation permissions

Copy link
Member

@0x2b3bfa0 0x2b3bfa0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The GitLab issue doesn't have anything to do with the modifications introduced in this pull request.
Moving these concerns to #447...

Copy link
Member

@0x2b3bfa0 0x2b3bfa0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way, are we accidentally deleting half of the package-lock.json file?

Copy link
Member

@0x2b3bfa0 0x2b3bfa0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, it was because of the pacakge-lock.json version downgrade.

@0x2b3bfa0
Copy link
Member

@DavidGOrtega, please run again the GitLab check; it should succeed.

@DavidGOrtega
Copy link
Contributor Author

DavidGOrtega commented Mar 16, 2021

I did it a few seconds before ;)

@DavidGOrtega DavidGOrtega merged commit f211b2d into release/v0.3.1 Mar 16, 2021
@DavidGOrtega DavidGOrtega deleted the runner-startup-script branch March 16, 2021 10:56
@0x2b3bfa0 0x2b3bfa0 added this to the 0.3.1 milestone Mar 16, 2021
DavidGOrtega added a commit that referenced this pull request Mar 18, 2021
…#431)

* [create-pull-request] automated change (#425)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update dependacron pull request step (#426)

This commit updates the major version for the peter-evans/create-pull-request GitHub Action step.

Required in order to avoid a fatal error caused by the  hard deprecation of the `set-env` and `add-path` standard output commands after CVE-2020-15228.

* Add sanity check for cml-publish with filesystem paths (#427)

* Add sanity check for cml-publish files

Closes #308 and probably also closes #401

* Restyled by prettier (#428)

Co-authored-by: Restyled.io <[email protected]>

* Add tests for cml-publish file errors

* Also removes an stray leading dot on the introduced error message

* Embrace native file error messages for cml-publish

Co-authored-by: restyled-io[bot] <32688539+restyled-io[bot]@users.noreply.github.com>
Co-authored-by: Restyled.io <[email protected]>

* Add destroy timeout feature (#419)

* [create-pull-request] automated change (#441)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Helio Machado <[email protected]>

* Add support for singleton runners (#422)

* Add support for singleton runners

The --reuse-existing flag will cause cml-runner
to look up for already existing runners with the
specified --labels and skip creating a new one
if that's the case.

* Deprecate --name with a warning

* Apply pre-review suggestions and fixes

* Comment out deprecation warning
* Remove unnecessary comparison
* Rename reuse-existing to reuse
* Fix misconception about empty array truthiness
* Simplify reuse by name logic
* Add missing awaits
* Give precedence to name deduplication over label deduplication
* Remove commented code

* Startup script (#445)

* Startup script

* lint

* snapshots

* Add debugging message for #443 (#448)

This commit doesn't completely fix #443, but closes it until we can reproduce again the error.

* Bitbucket-1000-handling

* bump version

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: restyled-io[bot] <32688539+restyled-io[bot]@users.noreply.github.com>
Co-authored-by: Restyled.io <[email protected]>
Co-authored-by: DavidGOrtega <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants