-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cml-publish ERR_INVALID_URL #443
Comments
This comment has been minimized.
This comment has been minimized.
I have been able to reproduce this issue artificially by mocking the asset server and replying with an empty If this is a real issue, it's was probably caused on the backend. |
Yes. I have been noticing it from and you are right its in the backend |
This comment has been minimized.
This comment has been minimized.
I haven't been able to isolate any deterministic cause for this issue after reading the backend code and performing some tests. I'll set up a similar function on my private account and try to reproduce the issue repeatedly. |
Excerpt from the workflow run linked on the original post including log timestamps: Fri, 12 Mar 2021 12:24:48 GMT TypeError [ERR_INVALID_URL]: Invalid URL:
Fri, 12 Mar 2021 12:24:48 GMT at onParseError (internal/url.js:257:9)
Fri, 12 Mar 2021 12:24:48 GMT at new URL (internal/url.js:333:5)
Fri, 12 Mar 2021 12:24:48 GMT at watermark_uri (/cml/src/utils.js:135:15)
Fri, 12 Mar 2021 12:24:48 GMT at CML.publish (/cml/src/cml.js:110:13)
Fri, 12 Mar 2021 12:24:48 GMT at processTicksAndRejections (internal/process/task_queues.js:97:5)
Fri, 12 Mar 2021 12:24:48 GMT at async run (/cml/bin/cml-publish.js:25:18) {
Fri, 12 Mar 2021 12:24:48 GMT input: '',
Fri, 12 Mar 2021 12:24:48 GMT code: 'ERR_INVALID_URL'
Fri, 12 Mar 2021 12:24:48 GMT } |
What puzzles me is that there isn't any CloudWatch log with that timestamp and, after correlating newer runs like 2096426611, I haven't found any noticeable clock skew. It looks like the request didn't even trigger the lambda function and errored somewhere near API Gateway, so I declare myself incapable of fixing this issue with a single sample, no means to reproduce it and no logs. @DavidGOrtega, unless you choose otherwise, I'm closing this issue by adding an user-friendly error with debug information just in case somebody is able to reproduce it in the future. |
This commit doesn't fix #443, but closes it until we can reproduce again the error.
This commit doesn't fix #443, but closes it until we can reproduce again the error.
This commit doesn't fix #443, but closes it until we can reproduce again the error.
This commit doesn't fix #443, but closes it until we can reproduce again the error.
…#431) * [create-pull-request] automated change (#425) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update dependacron pull request step (#426) This commit updates the major version for the peter-evans/create-pull-request GitHub Action step. Required in order to avoid a fatal error caused by the hard deprecation of the `set-env` and `add-path` standard output commands after CVE-2020-15228. * Add sanity check for cml-publish with filesystem paths (#427) * Add sanity check for cml-publish files Closes #308 and probably also closes #401 * Restyled by prettier (#428) Co-authored-by: Restyled.io <[email protected]> * Add tests for cml-publish file errors * Also removes an stray leading dot on the introduced error message * Embrace native file error messages for cml-publish Co-authored-by: restyled-io[bot] <32688539+restyled-io[bot]@users.noreply.github.com> Co-authored-by: Restyled.io <[email protected]> * Add destroy timeout feature (#419) * [create-pull-request] automated change (#441) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Helio Machado <[email protected]> * Add support for singleton runners (#422) * Add support for singleton runners The --reuse-existing flag will cause cml-runner to look up for already existing runners with the specified --labels and skip creating a new one if that's the case. * Deprecate --name with a warning * Apply pre-review suggestions and fixes * Comment out deprecation warning * Remove unnecessary comparison * Rename reuse-existing to reuse * Fix misconception about empty array truthiness * Simplify reuse by name logic * Add missing awaits * Give precedence to name deduplication over label deduplication * Remove commented code * Startup script (#445) * Startup script * lint * snapshots * Add debugging message for #443 (#448) This commit doesn't completely fix #443, but closes it until we can reproduce again the error. * Bitbucket-1000-handling * bump version Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: restyled-io[bot] <32688539+restyled-io[bot]@users.noreply.github.com> Co-authored-by: Restyled.io <[email protected]> Co-authored-by: DavidGOrtega <[email protected]>
Happened here
The text was updated successfully, but these errors were encountered: