Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install ldid with brew #1217

Merged
merged 6 commits into from
Oct 11, 2022
Merged

Install ldid with brew #1217

merged 6 commits into from
Oct 11, 2022

Conversation

0x2b3bfa0
Copy link
Member

@0x2b3bfa0 0x2b3bfa0 commented Oct 8, 2022

Not sure if it's better to do this or just keep the previous code and git checkout a23f0faadd29ec00a6b7fb2498c3d15af15a7100 to make sure we're running the code we want... until somebody manages to break SHA1DC. 😅

@0x2b3bfa0 0x2b3bfa0 added security Sensitive flaws releases Shipping builds labels Oct 8, 2022
@0x2b3bfa0 0x2b3bfa0 requested a review from dacbd October 8, 2022 16:43
@0x2b3bfa0 0x2b3bfa0 self-assigned this Oct 8, 2022
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal October 8, 2022 16:43 Inactive
@0x2b3bfa0

This comment was marked as outdated.

@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal October 8, 2022 17:05 Inactive
@dacbd
Copy link
Contributor

dacbd commented Oct 8, 2022

so just wait for conda-forge/ldid-feedstock#7 to be safe then?

@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal October 8, 2022 17:23 Inactive
@0x2b3bfa0 0x2b3bfa0 added the blocked Dependent on something else label Oct 8, 2022
@0x2b3bfa0
Copy link
Member Author

Blocked by conda-forge/ldid-feedstock#7

@0x2b3bfa0

This comment was marked as outdated.

@dacbd

This comment was marked as off-topic.

dacbd
dacbd previously approved these changes Oct 8, 2022
Copy link
Contributor

@dacbd dacbd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/rubber_stamp
#blocked

@0x2b3bfa0
Copy link
Member Author

@dacbd, Homebrew/homebrew-core#112702 won the brew & conda race; should we use it?

@0x2b3bfa0
Copy link
Member Author

Note that brew requires a workaround (actions/runner-images#6283) to run because GitHub was feeling trigger-happy and broke it.

steps:
- run: for path in /home/linuxbrew/.linuxbrew/{s,}bin; do echo $path; done >> $GITHUB_PATH
- run: brew install ldid

@carlocab
Copy link

carlocab commented Oct 9, 2022

You can also use the setup-homebrew action, with something like

    steps:
      - name: Set up Homebrew
        id: set-up-homebrew
        uses: Homebrew/actions/setup-homebrew@29b2973f18e5aca5443f4b3d87f68eda7a27b22b

@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal October 11, 2022 22:50 Inactive
@0x2b3bfa0 0x2b3bfa0 changed the title Install ldid with conda Install ldid with brew Oct 11, 2022
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal October 11, 2022 22:50 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal October 11, 2022 22:51 Inactive
@0x2b3bfa0 0x2b3bfa0 removed the blocked Dependent on something else label Oct 11, 2022
@0x2b3bfa0 0x2b3bfa0 requested a review from dacbd October 11, 2022 22:59
Copy link
Contributor

@dacbd dacbd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:rubber_stamp:
but feels weird to use homebrew for not mac things... do we care, should we revisit this after a conda update?

@0x2b3bfa0
Copy link
Member Author

feels weird to use homebrew for not mac things

It's indeed unusual, but “linuxbrew” is handy. I use it on my personal projects to install Hashicorp Packer on GitHub Actions with a single line. 🤷🏼‍♂️

@0x2b3bfa0
Copy link
Member Author

should we revisit this after a conda update?

We could, if conda feels better for “not-scientific-Python things” 😈

@0x2b3bfa0 0x2b3bfa0 merged commit 926f62c into master Oct 11, 2022
@0x2b3bfa0 0x2b3bfa0 deleted the ldid-conda branch October 11, 2022 23:07
@0x2b3bfa0
Copy link
Member Author

Thanks for all your help with Homebrew/homebrew-core#112702, @carlocab!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
releases Shipping builds security Sensitive flaws
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants