Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ldid: linux compatibility #112702

Merged
merged 1 commit into from
Oct 9, 2022
Merged

ldid: linux compatibility #112702

merged 1 commit into from
Oct 9, 2022

Conversation

0x2b3bfa0
Copy link
Contributor

@0x2b3bfa0 0x2b3bfa0 commented Oct 9, 2022 •
edited
Loading

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@BrewTestBot BrewTestBot added go Go use is a significant feature of the PR or issue no Linux bottle Formula has no Linux bottle labels Oct 9, 2022
@0x2b3bfa0 0x2b3bfa0 marked this pull request as ready for review October 9, 2022 07:23
@0x2b3bfa0 0x2b3bfa0 mentioned this pull request Oct 9, 2022
Merged
carlocab
carlocab reviewed Oct 9, 2022
View reviewed changes
Formula/ldid.rb Outdated Show resolved Hide resolved
@carlocab carlocab added CI-no-bottles Merge without publishing bottles CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Oct 9, 2022
@BrewTestBot BrewTestBot removed the go Go use is a significant feature of the PR or issue label Oct 9, 2022
@carlocab
Copy link
Member

carlocab commented Oct 9, 2022

We don't need go here if all we're looking for is a MachO binary. Fixed that up for you.

@0x2b3bfa0
Copy link
Contributor Author

Thanks! I skimmed through the “add a test to the formula” section and didn't notice the standard test fixtures bullet point. 🤦🏼‍♂️

@0x2b3bfa0 0x2b3bfa0 requested a review from carlocab October 9, 2022 08:18
carlocab
carlocab approved these changes Oct 9, 2022
View reviewed changes
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! A Linux build that you can brew install will be uploaded shortly. (You may need to brew update first.)

@carlocab carlocab merged commit 029eb1f into Homebrew:master Oct 9, 2022
@0x2b3bfa0 0x2b3bfa0 deleted the patch-1 branch October 9, 2022 08:19
@carlocab
Copy link
Member

carlocab commented Oct 9, 2022

Available starting d275a91. Thanks for your contribution!

@0x2b3bfa0
Copy link
Contributor Author

Thank you very much for all your help! 🙏🏼

@github-actions github-actions bot added the outdated PR was locked due to age label Nov 9, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@carlocab carlocab carlocab approved these changes

Assignees
No one assigned
Labels
CI-no-bottles Merge without publishing bottles CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. no Linux bottle Formula has no Linux bottle outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0x2b3bfa0 @carlocab @BrewTestBot