Fix release workflows, again #1214
Conversation
* Use fallback false value on test-deploy workflow * Replace `softprops/action-gh-release` with `gh`
| @@ -102,47 +102,29 @@ jobs: | |||
| registry-url: https://registry.npmjs.org | |||
| - run: npm install | |||
| - run: | |||
| npm ${{ inputs.release && 'publish' || 'publish --dry-run' }} | |||
| npm ${{ inputs.release && 'publish' || 'publish --dry-run' }} || ${{ | |||
There was a problem hiding this comment.
why not just use conditional workflow steps?
There was a problem hiding this comment.
Agreed, it would be much clearer for any post analysis.
There was a problem hiding this comment.
But we'd need to use up some of our newline quota 😄
There was a problem hiding this comment.
Note that the extra || ${{ inputs.release && 'true' || 'false' }} was immediately reverted with #1215; I added it to make the (non-dry) publish process idempotent, because trying to publish an existing version would fail.
There was a problem hiding this comment.
Ternary operator
- run: npm ${{ inputs.release && 'publish' || 'publish --dry-run' }}
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}Conditional steps
- if: inputs.release == true
run: npm publish
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
- if: inputs.release != true
run: npm publish --dry-run
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}There was a problem hiding this comment.
Happy to deplete our newline quota if you feel it's necessary 😄
There was a problem hiding this comment.
WTB this as a future required change for the next person to edit said lines.
softprops/action-gh-releasewithgh