Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package accidentally bumped to v18 #1224

Closed
2 tasks
0x2b3bfa0 opened this issue Oct 12, 2022 · 0 comments
Closed
2 tasks

Package accidentally bumped to v18 #1224

0x2b3bfa0 opened this issue Oct 12, 2022 · 0 comments
Assignees
Labels
bug Something isn't working releases Shipping builds

Comments

@0x2b3bfa0
Copy link
Member

Summary

For a short lapse of time, the CML package was published with a wrong version number; specifically, 18 major versions in the future.

Impact

None, for users.

  • Our project isn't being used as a library; thus, users pinning the wrong version isn't a concern.
  • Availability wasn't affected.

Timeline

  1. 2022-10-08 04:28:31 UTC — @0x2b3bfa0 opens Fix release workflows, again #1214 to fix the build process

  2. 2022-10-08 04:28:40 UTC — @0x2b3bfa0 merges Fix release workflows, again #1214

  3. 2022-10-08 04:31:25 UTC — @0x2b3bfa0 informs of a couple of impending unapproved merges with #cml/p1665203485173579

  4. 2022-10-08 04:34:22 UTC — @0x2b3bfa0 opens Fast-forward version number to v0.18.3 #1215 to manually fast-forward the version number, and accidentally swaps the minor and major components 🙈

  5. 2022-10-08 04:34:28 UTC — @0x2b3bfa0 merges Fast-forward version number to v0.18.3 #1215

  6. 2022-10-08 15:34:27 UTC — @dacbd notifies @0x2b3bfa0 (twice) about the mistake through a Slack direct message, but the former ceases the conversation without being understood 🙈

  7. 2022-10-11 circa 14:40:00 UTC — @0x2b3bfa0 joins the weekly meeting and is informed by @casperdcl of the mistake

  8. 2022-10-11 circa 15:40:00 UTC — @0x2b3bfa0 deletes the v18.0.4 release and tag from GitHub

  9. 2022-10-11 16:27:59 UTC — @0x2b3bfa0 runs npm unpublish @dvcorg/[email protected] through GitHub Actions (3228563638)

Intervals

  • Time to first warning (4-6) — approximately 11 hours
  • Time to notice (4-7) — approximately 3 days and 10 hours (weekend + @0x2b3bfa0 day off included)
  • Time to fix (7-9) — approximately 1 hour and 47 minutes (meetings included)

Cause1 analysis

  • @0x2b3bfa0 committed (literally) a typo when manually editing the version number

Prevention

  • Write a cml-playground check to make sure major version equals 0
  • Pay more attention when manually editing a version number

Footnotes

  1. There's no such thing as a root cause, by the way; causes that can be plausibly deeemed as such are out of scope for a technical document.

@0x2b3bfa0 0x2b3bfa0 added bug Something isn't working releases Shipping builds labels Oct 12, 2022
@0x2b3bfa0 0x2b3bfa0 self-assigned this Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working releases Shipping builds
Projects
None yet
Development

No branches or pull requests

1 participant