-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(deps): update to react 18 #1049
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
84a7fce
to
b68e214
Compare
b68e214
to
9f3b575
Compare
Can you give me the repo permission, I'll help you if I can? thanks |
f7b0a48
to
67ba913
Compare
67ba913
to
c7638e3
Compare
c7638e3
to
7fb84ac
Compare
i should have given you access to the repo |
7fb84ac
to
f86ed09
Compare
To upgrade to React 18 you also need to check the deprecated types, one above all ReactChild: I believe there is a babel plugin that checks all the code. |
@sabato-galasso please be advised, i'm rebasing my branch to rename some commit messages since i'm getting commitlint errors due to missing subject/type in the previous commit messages that cause an automatic check to fail immediately |
@Nick87 I did a wrong merge, can you revert the last commit? I don't have permission. Thank you |
is this PR still meaningful? i was considering closing it since it seems to be going nowhere imho :) |
2bc3bbd
to
7578576
Compare
It hasn't been merged yet :( |
you can try to rebase and resolve conflicts, let's see if we can merge it |
@Lorezz and me are going to resolve conflicts and review this PR on Wed 26. |
@sabato-galasso @Virtute90 @Nick87 I tried to realign this branch with cc @Lorezz |
I looked at the branch of @Nick87, you need to do these operations:
and the tests should work correctly |
@Lorezz just updated tests and dependencies, we're testing an unstable build before merging this PR. |
Fixes #963
PR Checklist
main
branch.Short description of what this resolves:
Upgrade dependencies, react included