Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: remove defaultProps on Alert #1067

Closed
Virtute90 opened this issue Jun 5, 2024 · 1 comment · Fixed by #1049 or #1072
Closed

Fix: remove defaultProps on Alert #1067

Virtute90 opened this issue Jun 5, 2024 · 1 comment · Fixed by #1049 or #1072
Labels
enhancement

Comments

@Virtute90
Copy link
Collaborator

Nel componente Alert viene usato la proprietà defaultProps che è stata deprecata: Warn when Using DefaultProps on Function Components

image

La modifica si potrebbe aggiungere all'aggiornamento a React 18: #963 #1049

design-react-kit/src/Alert/Alert.tsx

Line 35 in 1074d49

Alert.defaultProps = defaultProps;

@Virtute90 Virtute90 changed the title Fix: remove defaultProps on Function Componente Fix: remove defaultProps on Function Component Jun 5, 2024
@astagi astagi linked a pull request Jun 24, 2024 that will close this issue
feat(deps): update to react 18 #1049
Merged
4 tasks
@astagi
Copy link
Member

astagi commented Jun 27, 2024

@Virtute90 su questa potresti mandare una PR? riparti pure anche da main poi mergio insieme all'aggiornamento alla 18 oppure fai sul branch dell'aggiornamento.. Grazie 🙏

@Virtute90 Virtute90 changed the title Fix: remove defaultProps on Function Component Fix: remove defaultProps on Alert Jun 28, 2024
Virtute90 added a commit to Virtute90/design-react-kit that referenced this issue Jun 28, 2024
@Virtute90
fix: italia#1067
2adf33d
@Virtute90 Virtute90 mentioned this issue Jun 28, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
2 participants
@astagi @Virtute90