Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not split questions over more pages #38

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Conversation

Witiko
Copy link
Contributor

@Witiko Witiko commented Apr 10, 2024

This PR fixes point 9 from ticket #10:

  • do not split questions over more pages

Here is how the Sample Exam Questions document looks after this PR:

image

See also istqborg/istqb_product_template#9.

@Witiko Witiko requested a review from danopolan April 10, 2024 12:27
@Witiko Witiko self-assigned this Apr 10, 2024
@Witiko Witiko changed the title Put each question in a vbox to prevent page breaks Do not split questions over more pages Apr 10, 2024
@danopolan
Copy link
Contributor

@Witiko I was commenting on this one right after creation, but not sure where my comment went :)
Anyway, I am just afraid what if a question will not fit on one page? Will it be split somehow gracefully over more pages or not?

@Witiko
Copy link
Contributor Author

Witiko commented Apr 17, 2024

Anyway, I am just afraid what if a question will not fit on one page? Will it be split somehow gracefully over more pages or not?

That's an excellent point. In such a case, the question would not break and would instead extend below the page foot.

Perhaps we can prevent splitting but only for questions that are no taller than 50% of page height? This way, we ensure that unsplittable questions will always fit a page and we can guarantee that no more than ~50% of page height will be empty when an unsplittable question has been moved to the next page. Of course, any percentage between 0% and 100% works.

@danopolan
Copy link
Contributor

AFAIK currently, there is no such question, but new modules tend to have longer questions due to tables and figures. I would keep the implementation as it is (extend long questions below the page foot) and proceed with updates once needed in specific cases.

@Witiko
Copy link
Contributor Author

Witiko commented Apr 19, 2024

OK, I will merge this PR then.

@Witiko Witiko merged commit aef1e73 into main Apr 19, 2024
6 checks passed
@Witiko Witiko deleted the fix/page-breaks-in-questions branch April 19, 2024 09:45
Witiko added a commit that referenced this pull request Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants